-
Notifications
You must be signed in to change notification settings - Fork 1.1k
IDE: Support jump to definition in imports #4199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Duhemm
merged 21 commits into
scala:master
from
dotty-staging:topic/go-to-definition-imports
Nov 16, 2018
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
3ceb552
Address review
Duhemm f49ab22
Improve IDE support for imports
Duhemm edf6230
Support multiple imports per line
Duhemm 07def6c
IDE: Support imports when renaming
Duhemm 034c20d
Style comments
Duhemm fbac8a0
Get rid of `RenameTree`
Duhemm 0cd46a1
IDE: Support renaming renaming imports
Duhemm 59945af
IDE: Support rename on renamed self types
Duhemm b2d8c9a
Address review comments
Duhemm b7ce60a
Be less precise about renaming and imports
Duhemm ab94c99
Be even less precise about renaming with imports
Duhemm 653756b
Move helpers for handling imports to tpd.scala
Duhemm facc581
Remove `Include.renamingImport`
Duhemm d09f900
Remove `SourceImportTree`
Duhemm 55de5b2
IDE: Generate fewer duplicates with imports
Duhemm 59b489d
IDE: Improve `Include` flags
Duhemm cf3c247
Address review comments
Duhemm 9963693
Improve renaming with overridden symbols
Duhemm ec6882c
Ask user when renaming overriding symbols
Duhemm 8dc5f8f
Show documentation for all imported symbols
Duhemm f88ad86
Address last review comments
Duhemm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.