Cache context base base in quote driver #4643
Conversation
nicolasstucki
force-pushed
the
cache-tasty-driver
branch
2 times, most recently
from
bf31454 to
e959e89
Compare
nicolasstucki
force-pushed
the
cache-tasty-driver
branch
from
e959e89 to
2a8f16b
Compare
nicolasstucki
force-pushed
the
cache-tasty-driver
branch
from
2a8f16b to
486007c
Compare
| import dotty.tools.dotc.tastyreflect.TastyImpl | ||
|
|
||
| class QuoteDriver extends Driver { | ||
| import tpd._ | ||
|
|
||
| def run[T](expr: Expr[T], settings: Settings[Run]): T = { | ||
| private[this] val contextBase: ContextBase = new ContextBase |
There was a problem hiding this comment.
I don't think this is thread-safe
There was a problem hiding this comment.
It is not and not intended to be. Each thread should generate its own toolbox. I will add documentation and thick how to check that they do not use the same compiler in two threads.
There was a problem hiding this comment.
Decided to make it thread-safe by synchronization instead. If someone wants parallelism they should create several instances of the Toolbox
There was a problem hiding this comment.
Decided to make it thread-safe by synchronization instead.
I don't see any synchronization logic in the code.
There was a problem hiding this comment.
I must have lost that commit in one of the reading. I will add it again.
There was a problem hiding this comment.
Searching for synchronized still finds nothing here?
There was a problem hiding this comment.
It is in #4746
nicolasstucki
force-pushed
the
cache-tasty-driver
branch
from
b56fda2 to
80266ae
Compare
|
Rebased |
Should be re-enbled in scala#4643
Should be re-enbled in scala#4643
* Cache the driver itself * Cache context base in the driver * Addapt toolbox settings * Use cached toolbox in tests
This reverts commit ce3f7b4.
nicolasstucki
force-pushed
the
cache-tasty-driver
branch
from
80266ae to
f781701
Compare
|
Rebased and reenabled test |
|
Also had a look. Seems good. |
This enables caching the compiler used of call
Expr.run.