Skip to content

Extract parser into its own phase #5613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

allanrenucci
Copy link
Contributor

Motivations:

  • Reuse phase infrastructure (e.g. -Ystop-after:parsing)
  • Make it easier to replace the parser (useful in the REPL for example)

@allanrenucci allanrenucci force-pushed the parser-phase branch 2 times, most recently from 900e5c4 to 04e0621 Compare December 17, 2018 10:48
@allanrenucci allanrenucci self-assigned this Dec 19, 2018
@Blaisorblade
Copy link
Contributor

Hey! We’re trying to shrink the PR queue! (Progressed/merged on all my PRs) Do you plan to resume this, or can we close it for now?
(I agree this would be nice BTW)

@biboudis
Copy link
Contributor

biboudis commented Jan 24, 2019

I believe that since this is a work in progress it shouldn't be lost, so no closing. But @allanrenucci if you have free time to write some guidelines for someone to take over that would be amazing! Merci!

@allanrenucci allanrenucci force-pushed the parser-phase branch 2 times, most recently from 847c110 to 610d845 Compare January 24, 2019 22:28
@allanrenucci
Copy link
Contributor Author

allanrenucci commented Jan 25, 2019

To move this forward, one would need to investigate the test failures. The dottydoc test failures should be relatively easy to fix. The cyclic and pickling errors on the other hand will require more expertise.

As a first step, one could try to extract the changes in 1b4be4b into a separate PR.

@allanrenucci allanrenucci removed their assignment Jan 25, 2019
@biboudis biboudis self-assigned this Jan 30, 2019
@biboudis
Copy link
Contributor

I will try to take over @allanrenucci

@allanrenucci allanrenucci force-pushed the parser-phase branch 2 times, most recently from 387855d to 1b4be4b Compare March 5, 2019 19:55
@b-studios
Copy link
Contributor

@biboudis we are again at shrinking the PR queue :) Any suggestions on how to proceed with this PR?

@biboudis
Copy link
Contributor

I guess rebasing and trying to make the tests work from the start. I started from pickling errors back then, but I think this needs a new round of debugging.

@biboudis biboudis removed their assignment Apr 27, 2021
@OlivierBlanvillain
Copy link
Contributor

I suggest closing and reopening if someone want to work on it. The last commits are from 2018 so I'm not sure rebasing would even be a sensible option here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants