-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Extract parser into its own phase #5613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
900e5c4
to
04e0621
Compare
Hey! We’re trying to shrink the PR queue! (Progressed/merged on all my PRs) Do you plan to resume this, or can we close it for now? |
I believe that since this is a work in progress it shouldn't be lost, so no closing. But @allanrenucci if you have free time to write some guidelines for someone to take over that would be amazing! Merci! |
847c110
to
610d845
Compare
To move this forward, one would need to investigate the test failures. The dottydoc test failures should be relatively easy to fix. The cyclic and pickling errors on the other hand will require more expertise. As a first step, one could try to extract the changes in 1b4be4b into a separate PR. |
I will try to take over @allanrenucci |
387855d
to
1b4be4b
Compare
1b4be4b
to
b2b2b05
Compare
This is an attempt at fixing stale symbol errors
b2b2b05
to
048a747
Compare
@biboudis we are again at shrinking the PR queue :) Any suggestions on how to proceed with this PR? |
I guess rebasing and trying to make the tests work from the start. I started from pickling errors back then, but I think this needs a new round of debugging. |
I suggest closing and reopening if someone want to work on it. The last commits are from 2018 so I'm not sure rebasing would even be a sensible option here... |
Motivations:
-Ystop-after:parsing
)