Skip to content

Fix/#55 #56 modules #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix/#55 #56 modules #58

wants to merge 2 commits into from

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Mar 12, 2014

Fixes of #55, #56, related to modules

odersky added 2 commits March 12, 2014 15:35
@odersky
Fix for scala#56
fae61cb 
newModuleSymbol failed before if owner was a term. Now we generate a symbolic termRef as a sourceModule
link which works also term owner, where owner.thisType gives NoProfix.
@odersky
Fix for scala#55
e2b879a 
Distringuish between ModifierFlags -- which can appear in trees -- and SourceModifierFlags -- which are
modifiers according to the language spec.
@odersky
Copy link
Contributor Author

odersky commented Mar 12, 2014

Review by @DarkDimius

@odersky
Copy link
Contributor Author

odersky commented Mar 12, 2014

The #56 fix is flawed. Stay tuned for another pull request.

@odersky odersky closed this Mar 12, 2014
@odersky odersky deleted the fix/#55-#56-modules branch March 12, 2014 15:41
WojciechMazur pushed a commit to WojciechMazur/dotty that referenced this pull request Mar 19, 2025
@tgodzik
Merge pull request scala#58 from scala/backport-lts-3.3-21831
a907d2e 
Backport "Don't warn for deprecated Thread.getId() calls in `ChromeTrace`" to 3.3 LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@odersky