Skip to content

Add updateCheckFiles to override tests check files with output #5894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2019

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Feb 11, 2019

  • Also updated testFromTasty checkfiles using it to remove first comment line
    which cannot be tested on Windows adn added missing EOLs.
  • Add --update-checkfiles to testCompilation
  • Replace testFromTasty with testCompilation --from-tasty

Also updated `testFromTasty` checkfiles using it to remove first comment line
which cannot be tested on Windows adn added missing EOLs.
@smarter
Copy link
Member

smarter commented Feb 11, 2019

  • We need a way to run this from the sbt command-line, I suggest testCompilation --update-check (by the way, I also think testFromTasty should be replaced with a flag passed to testCompilation).
  • In Scala 2's partest, the summary at the end gives you the exact command to run to update all failed check files (e.g. partest --update-check tests/run/foo.scala tests/run/bla.scala)
  • This needs to be documented in https://github.com/lampepfl/dotty/blob/master/docs/docs/contributing/workflow.md

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Last thing that could be useful would be a --help for testCompilation if you have time :)

@nicolasstucki nicolasstucki merged commit f04b2ea into scala:master Feb 12, 2019
@ghost ghost removed the stat:needs review label Feb 12, 2019
@nicolasstucki nicolasstucki deleted the add-update-checkfiles branch February 12, 2019 13:07
@nicolasstucki
Copy link
Contributor Author

Ping @biboudis note the change with testFromTasty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants