Move files after -sourcepath fix, fix sbt-dotty retrieval of dotty #7806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
move-files-4
branch
from
4e4eb69 to
c4d4fe1
Compare
|
There are some tests failing |
|
I noticed a few instances of |
Previously it was missing some source directories (in particular, src-bootstrapped and src-non-bootstrapped).
Some of them had been sitting here for a long time to work around issues with -sourcepath which should all be fixed now. Also remove non-bootstrapped toExpr which had been deprecated for a while.
In the dotty build, we rely on sbt-dotty to get the reference compiler and its dependencies. But when using a locally-published dotty as the reference compiler I ran into a situation where sbt-dotty failed to get some of the artifacts. It seems that this happens because it confuses the locally-published projects with the projects in the current build. Fixed by tweaking the way sbt-dotty retrieves dotty to make sure it never considers projects from the current build.
|
Ready for review. |
nicolasstucki
approved these changes
Jan 8, 2020
nicolasstucki
force-pushed
the
move-files-4
branch
from
94e7824 to
4c008f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.