-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Normalize definitions of compiler settings #7857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I guess that it wasn't like that to begin with since some "sentences" are not really complete sentences. |
Indeed, here is one example: PhasesSetting("-Ylog", "Log operations during") Would it not be useful to make them complete? |
I agree with soronpo, after all. Complete sentences should get a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM, thanks for taking the time to improve the docs!
I believe this is getting out of hand. The status quo is better than the fix. We either have to check more carefully where to put the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have dots in nonsensical places.
Thanks, @soronpo @odersky @anatoliykmetyuk for providing valuable feedback.
I will remove dots from incomplete sentences. |
Dots are removed from incomplete sentences. They are also removed from definitions, where dots might confuse more than help, e.g:
If you think removing dots from all definitions is even better for consistency reasons, just let me know and I will fix it asap. |
The goal of this simple community PR is to normalize compiler definitions by capitalizing the first word and adding
.
at the end of a sentence.