Skip to content

Normalize definitions of compiler settings #7857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2020

Conversation

nerush
Copy link
Contributor

@nerush nerush commented Dec 27, 2019

The goal of this simple community PR is to normalize compiler definitions by capitalizing the first word and adding . at the end of a sentence.

@soronpo
Copy link
Contributor

soronpo commented Jan 5, 2020

I guess that it wasn't like that to begin with since some "sentences" are not really complete sentences.

@nerush
Copy link
Contributor Author

nerush commented Jan 6, 2020

I guess that it wasn't like that to begin with since some "sentences" are not really complete sentences.

Indeed, here is one example:

PhasesSetting("-Ylog", "Log operations during")

Would it not be useful to make them complete?

odersky
odersky previously approved these changes Jan 6, 2020
@anatoliykmetyuk anatoliykmetyuk self-assigned this Jan 6, 2020
@odersky
Copy link
Contributor

odersky commented Jan 7, 2020

I agree with soronpo, after all. Complete sentences should get a ., others not. If that's too tedious we could also consider never adding .

@odersky odersky self-requested a review January 7, 2020 12:31
@odersky odersky dismissed their stale review January 7, 2020 12:32

Changed opinion

@odersky odersky removed their request for review January 7, 2020 12:32
Copy link
Contributor

@anatoliykmetyuk anatoliykmetyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM, thanks for taking the time to improve the docs!

@odersky
Copy link
Contributor

odersky commented Jan 8, 2020

I believe this is getting out of hand. The status quo is better than the fix. We either have to check more carefully where to put the .s or leave them out altogether (which would be the simplest fix).

Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have dots in nonsensical places.

@nerush
Copy link
Contributor Author

nerush commented Jan 8, 2020

Thanks, @soronpo @odersky @anatoliykmetyuk for providing valuable feedback.

Don't have dots in nonsensical places.

I will remove dots from incomplete sentences.

@nerush
Copy link
Contributor Author

nerush commented Jan 8, 2020

Dots are removed from incomplete sentences. They are also removed from definitions, where dots might confuse more than help, e.g:

BooleanSetting("-Yretain-trees", "Retain trees for top-level classes, accessible from ClassSymbol#tree")

If you think removing dots from all definitions is even better for consistency reasons, just let me know and I will fix it asap.

@anatoliykmetyuk anatoliykmetyuk merged commit dc41bc9 into scala:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants