Skip to content

Extract Tree utils from Reflection #8193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Feb 4, 2020

  • Allows TreeMap, TreeTraverser and TreeAccumulator to be extended in non local classes
  • Removes logic that does not belong in Reflection

@nicolasstucki nicolasstucki self-assigned this Feb 4, 2020
@nicolasstucki nicolasstucki force-pushed the extract-tree-utils-from-reflection branch from bf01a4d to d10ff33 Compare February 4, 2020 15:54
@nicolasstucki nicolasstucki marked this pull request as ready for review February 4, 2020 17:15
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

* Allows TreeMap, TreeTraverser and TreeAccumulator to be extended in non local classes
* Removes logic that does not belong in Reflection
@nicolasstucki nicolasstucki force-pushed the extract-tree-utils-from-reflection branch from d10ff33 to 9089a02 Compare February 5, 2020 11:14
@nicolasstucki nicolasstucki force-pushed the extract-tree-utils-from-reflection branch from 9089a02 to 06da51f Compare February 5, 2020 11:15
@nicolasstucki nicolasstucki merged commit 669423a into scala:master Feb 5, 2020
@nicolasstucki nicolasstucki deleted the extract-tree-utils-from-reflection branch February 5, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants