-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Prototype for proposed main method generation scheme #8776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f22c2a4
to
2295aa4
Compare
Would it be possible to rename |
|
I like it. |
* tagged line. | ||
* `body` what comes before the first tagged line | ||
*/ | ||
case class DocComment(body: String, tags: Map[String, List[String]]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that we already have logic for parsing documentation comments in the compiler for the benefit of dottydoc: https://github.com/lampepfl/dotty/blob/master/compiler/src/dotty/tools/dotc/util/CommentParsing.scala / https://github.com/lampepfl/dotty/blob/master/compiler/src/dotty/tools/dotc/core/Comments.scala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The file here was meant as a demonstrator that it's easy to parse doc comments. Maybe we should make CommentParsing.scala
generally available instead. It will be work to document everything properly though since it's a large API.
I first thought there'd be a conflict with the current compiler-generated version, but there isn't after all.
We forgot the type parameters, which caused from-tasty and pickling tests to fail. We should probably disallow these forms of aliases and check for this.
- Communicate a single fully qualified wrapper method name instead of classname/methodname - Allow to add an annotation to a wrapper method
Change nomenclature from main methods and commands to entry points and wrappers, since the scheme is now more general than just main method generation.
This one is subsumed by run/decorators now.
No description provided.