Re-architecture staging phase and fix all known issues of that phase #8796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
reimplement-staging-phase
branch
from
2acb6f7 to
c6f67f1
Compare
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
reimplement-staging-phase
branch
8 times, most recently
from
2d09b0d to
c8306d0
Compare
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
reimplement-staging-phase
branch
2 times, most recently
from
8337eb0 to
3df9139
Compare
|
@odersky this PR is ready for review. The CLA failed to finish. |
|
In our first implementation, we assumed that handling levels of type and terms would be quite similar. We said that types and term can only be used at the same level ... with some exceptions for types that can be healed or are used at a lower level in a macro. Since then we have realized that in general types can be used at any level, but if used in a larger level they must be healed. In the previous implementation tried to patch this in different places. Instead, this one handles types and terms as two different entities that need to be handled in their own way. |
nicolasstucki
changed the title
Fix scala#6140, fix scala#6772, fix scala#7030, fix scala#7892, fix scala#7997, fix scala#8651 and improve scala#8100. Differences with previous implementation * Only track and check levels within quotes or splices * Track levels of all symbols not at level 0 * Split level checking into specialized variants for types and terms (healType/healTermType) * Detect inconsistent types rather than try to detect consistent ones * Check/heal term inconsistencies only on leaf nodes (TypeTree, RefTree, Ident, This)
nicolasstucki
force-pushed
the
reimplement-staging-phase
branch
from
3df9139 to
c03cb65
Compare
|
Rebased |
odersky
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6140, fix #6772, fix #7030, fix #7892, fix #7997, fix #8651 and improve #8100.
Differences with previous implementation