Implement compiletime.code with a macro #8859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
reimplement-compiletime-code
branch
3 times, most recently
from
3dbbcf0 to
6d772ed
Compare
Now, the implemetation is simpler with macros.
nicolasstucki
force-pushed
the
reimplement-compiletime-code
branch
from
6d772ed to
b6995d5
Compare
|
Note that I changed the printer. Now it shows the actual code rather than a simplified view of it. I am considering adding an alternative that would print the actual source code of the parameters. |
liufengyun
approved these changes
May 2, 2020
| * ``` | ||
| * | ||
| * @note only by-name arguments will be displayed as "code". | ||
| * Other values may display unintutively. | ||
| */ | ||
| inline def (self: => StringContext) code (args: => Any*): String = ??? | ||
| transparent inline def (inline self: StringContext) code (inline args: Any*): String = ${ codeExpr('self, 'args) } |
There was a problem hiding this comment.
It is not clear to me why we need transparent, given that the result type is always String.
There was a problem hiding this comment.
It is because we want this to return a string literal that can be constant folded with other string literals. Also, the error method used the type of the string know the value.
There was a problem hiding this comment.
The intrinsic implementation was also transparent, but we forgot to mark the definition as such.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the implementation is simpler with macros. At the time we did not have pattern matching on quoted code.