Add space complexity tracker for #9203 #9237
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think if possible we should use as much as possible the same logic (and the same compiler flag) when implicit search produces a lot of tree and when inlining does, but I'll let @nicolasstucki review this and decide. |
anatoliykmetyuk
force-pushed
the
space-complexity-tracker
branch
from
df7579f to
969b126
Compare
nicolasstucki
suggested changes
Jun 29, 2020
| val res = task | ||
| val after = size | ||
| val delta = after - before | ||
| if delta > 100000 |
There was a problem hiding this comment.
This should probably not be a constant. We should have a setting that allows us to modify this limit. We should probably use XmaxInlinedTrees (and maybe rename it).
| val after = size | ||
| val delta = after - before | ||
| if delta > 100000 | ||
| println( // ctx.warning does not output the message in this place, probably waits |
There was a problem hiding this comment.
Why not emit an error as we do in Inliner.scala#L132? There we return an errorTree to avoid further expansion, this may also work here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctx.source.nextIdinstead ofctx.base.uniquesSizesdoes not appear to be tracking the issue in question properly.printlnis ugly, but I found thatctx.warningdoes not flush immediately in that position. When dealing with an issue like #9203, it seems it won't flush at all until the compiler crashes with the OOME. Am I missing something here? Regardless, I thinkprintlnis fine since this is a best-effort lowest-cost warning for a pathological case that people should not be encountering in first place.