Skip to content

Fix #75: Publish vsix files on release #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

anatoliykmetyuk
Copy link
Contributor

No description provided.

@anatoliykmetyuk
Copy link
Contributor Author

So far it seems that only scala-lang.scala visx file is generated. However, in the issue @sideeffffect mentioned also the scala-lang.scala-snippets vsix file. Does anyone know where exactly the latter comes from?

@sideeffffect
Copy link

Seems like snippets has been canceled: #18

btw, please make sure that the format of the name of the file is the same as on VS Marketplace, e.g. scala-lang.scala-0.3.9.vsix (and not something like scala-0.3.9.vsix)

🙏

@anatoliykmetyuk
Copy link
Contributor Author

Done. That deployment logic of Travis looks fishy though, I'm not sure if this will work. They required me to generate a GitHub API key which is generated on a per-profile basis. If that key is tied to my account, the publishing might fail because I don't have the write rights for this repo.

@nicolasstucki nicolasstucki merged commit 6994c53 into scala:master Mar 11, 2020
@anatoliykmetyuk
Copy link
Contributor Author

@nicolasstucki can you give me the write permissions to the repo? The API token used in this PR is associated with my account, Travis might not be able to publish if I don't have the write access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants