add get_agglomerate_graph to annotation #1361
Conversation
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
| return file_path | ||
|
|
||
| def get_agglomerate_graph(self, agglomerate_id: int) -> AgglomerateGraph: | ||
| """Get the agglomerate graph for the specified agglomerate id. |
There was a problem hiding this comment.
maybe note that this works only if the annotation is a proofreading annotation (aka has an editable mapping). Maybe also note that it works only for single-volume-layer annotations
| AgglomerateGraph: The agglomerate graph for the specified agglomerate id. | ||
| Raises: | ||
| ValueError: If the agglomerate id is not valid. |
There was a problem hiding this comment.
Note that the tracingstore_client may also raise exceptions if the server response is not 200 or the response has an unexpected format
| protobuf_binary_response = self._get(route) | ||
| protobuf_binary = protobuf_binary_response.content | ||
| agglomerate_graph = AgglomerateGraph.from_proto(protobuf_binary) | ||
| return agglomerate_graph |
There was a problem hiding this comment.
Could the proto parsing be extracted to a helper method in the abstract_api_client? similar to _get_json, with agglomerate_graph_pb2.AgglomerateGraph as a type parameter?
AgglomerateGraph.fromProto could then not take the raw bytes but instead the already parsed proto?
| @@ -0,0 +1,71 @@ | |||
| // refresh with `protoc --python_out . webknossos/proofreading/agglomerate_graph.proto --pyi_out .` | |||
There was a problem hiding this comment.
This file will not be refreshed, though, is it? I think it is the source? Maybe the comment could be more explanatory.
Also, this file is copied from the webknossos repository, right? That should probably also be noted so that they don’t diverge.
| @@ -0,0 +1,155 @@ | |||
| from collections.abc import Iterable as _Iterable | |||
There was a problem hiding this comment.
could the generated files be in a folder named “generated” or similar, to mark this for other developers?
Description:
Todos:
Make sure to delete unnecessary points or to check all before merging: