Skip to content

Add zarrita support #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Jun 20, 2023
Merged

Add zarrita support #912

merged 32 commits into from
Jun 20, 2023

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Jun 12, 2023 •
edited
Loading

Description:

  • Implements the new Zarr v3 specification including sharding by adding zarrita as a storage backend. To activate zarrita, an environment variable WK_USE_ZARRITA must be set. zarrita will then also be used for Zarr v2 (current version) data.
  • Adds a Zarr3 data format, which should be compatible with Webknossos (needs testing)
  • Refactors all warnings to have a prefix, e.g. [WARNING] or [INFO]

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog
  • Updated Documentation
  • Added / Updated Tests

@normanrz normanrz marked this pull request as ready for review June 14, 2023 17:44
normanrz
normanrz commented Jun 15, 2023
View reviewed changes
.github/workflows/ci.yml Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-format...

@normanrz normanrz self-assigned this Jun 15, 2023
@normanrz normanrz requested a review from markbader June 15, 2023 07:07
normanrz
normanrz commented Jun 15, 2023
View reviewed changes
...ssos/tests/cassettes/test_annotation/test_annotation_from_url[61c20205010000cc004a6356].yaml Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these cassette files are auto-generated and don't need review.

markbader
markbader reviewed Jun 19, 2023
View reviewed changes
Copy link
Contributor

@markbader markbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I commented on some smaller issues but would already approve this PR.

@normanrz normanrz merged commit c36301a into master Jun 20, 2023
@normanrz normanrz deleted the zarrita branch June 20, 2023 15:51
@normanrz normanrz mentioned this pull request Jun 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbader markbader markbader approved these changes

Assignees

@normanrz normanrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@normanrz @markbader