Volume Tracing Stream: Skip invalid buckets #3541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe that this happens for tracings edited during the fossildb overload. It does not happen for my new tracings and also not for my old tracings. |
jfrohnhofen
reviewed
Dec 7, 2018
| def bucketStreamWithVersion(dataLayer: VolumeTracingLayer, resolution: Int, version: Option[Long]): Iterator[(BucketPosition, Array[Byte], Long)] = { | ||
| val key = buildKeyPrefix(dataLayer.name, resolution) | ||
| new VersionedBucketIterator(key, volumeDataStore, version) | ||
| new VersionedBucketIterator(key, volumeDataStore, version).flatMap(item => item) |
There was a problem hiding this comment.
.flatten should do the same thing
There was a problem hiding this comment.
But I am apparently to late to the party :(
jfrohnhofen
pushed a commit
that referenced
this pull request
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only explanation I can see for the None.get as posted here is invalid bucket keys being returned by the getMultipleKeys. This is troubling and we should look into the fossildb contents. However, since wK can show volume data for these tracings, the download (+copy to my account) may be fixed when we just skip all the invalid keys.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated changelog[ ] Updated migration guide if applicable[ ] Updated documentation if applicabledatastoretracingstore update after deployment