Skip to content

Conversation

leowe
Copy link
Contributor

@leowe leowe commented Jun 29, 2022

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Go to a volume annotation with a mapping file in webknossos
  • edit the segmentation and create a new segment
  • request a bounding box that contains that segment, e.g. http://localhost:9000/tracings/volume/zarr/e1d6f00c-84ad-494c-9134-a9deefa4ecc7/1/0.2.4.1?token=secretSampleUserToken
  • save response and check whether it contains the new segment, e.g. in python
import numpy as np

f = open("file.bin", "r")
a = np.fromfile(f, dtype=np.uint32)

Issues:


  • Needs datastore update after deployment
  • Ready for review

@leowe leowe requested a review from fm3 June 29, 2022 16:31
@leowe leowe self-assigned this Jun 29, 2022
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me already :) I added one qustion about empty fallback layer buckets, could you have a look?
I did not yet get to testing this, I hope I will get to that in the coming days.

Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 🎉 thanks for the easy-to-follow steps to test! :)
I added a few more small suggestions for the code

@normanrz normanrz added the zarr label Jul 1, 2022
@leowe leowe requested a review from fm3 July 5, 2022 15:06
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@leowe leowe enabled auto-merge (squash) July 5, 2022 15:26
@leowe leowe merged commit 6db50a5 into master Jul 5, 2022
@leowe leowe deleted the zarr-streaming-editable-mapping-support branch July 5, 2022 17:10
@leowe leowe mentioned this pull request Aug 4, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mappings for Volume annotation zarr streaming

3 participants