-
Notifications
You must be signed in to change notification settings - Fork 29
Zarr streaming editable mapping support #6310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… annotation zarr streaming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me already :) I added one qustion about empty fallback layer buckets, could you have a look?
I did not yet get to testing this, I hope I will get to that in the coming days.
...tore/app/com/scalableminds/webknossos/tracingstore/controllers/VolumeTracingController.scala
Outdated
Show resolved
Hide resolved
…scalableminds/webknossos into zarr-streaming-editable-mapping-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me 🎉 thanks for the easy-to-follow steps to test! :)
I added a few more small suggestions for the code
...tore/app/com/scalableminds/webknossos/tracingstore/controllers/VolumeTracingController.scala
Outdated
Show resolved
Hide resolved
...tore/app/com/scalableminds/webknossos/tracingstore/controllers/VolumeTracingController.scala
Outdated
Show resolved
Hide resolved
...tore/app/com/scalableminds/webknossos/tracingstore/controllers/VolumeTracingController.scala
Outdated
Show resolved
Hide resolved
…ngstore/controllers/VolumeTracingController.scala Co-authored-by: Florian M <[email protected]>
…ngstore/controllers/VolumeTracingController.scala Co-authored-by: Florian M <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
URL of deployed dev instance (used for testing):
Steps to test:
http://localhost:9000/tracings/volume/zarr/e1d6f00c-84ad-494c-9134-a9deefa4ecc7/1/0.2.4.1?token=secretSampleUserToken
Issues: