Skip to content

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jul 29, 2022

As discussed in #6241, the naming scheme for dataclass custom constructors should be fromX(). This convention was already largely used since #6249 and #6195 – this PR replaces the remaining few instances.

Steps to test:

  • CI should be enough, I only used IDE search + replace (except for Timespan, please read that one)

Issues:


  • Needs datastore update after deployment
  • Ready for review

@fm3 fm3 requested a review from jstriebel July 29, 2022 12:41
@fm3 fm3 self-assigned this Jul 29, 2022
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fm3 fm3 merged commit f9d1340 into master Aug 1, 2022
@fm3 fm3 deleted the dataclass-from branch August 1, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor backend: dataclass static function naming: from vs createFrom

2 participants