Skip to content

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Nov 22, 2023

This PR enables the animations feature for all users and add a small example video to the modal.

image

Steps to test:

  • None

Issues:

DO NOT MERGE YET


(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz self-assigned this Nov 22, 2023
@hotzenklotz hotzenklotz requested a review from normanrz November 22, 2023 13:48
@hotzenklotz hotzenklotz marked this pull request as ready for review November 22, 2023 13:49
Copy link
Member

@normanrz normanrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍
Since we only allow 2 jobs to be run in parallel and these videos take up to 12h to render. I am a bit worried that the animations will starve out other more important jobs such as data import conversion. Same problem with infer_neurons.
I think we might need to restrict these heavy jobs to only one concurrent and open up more slots for import. cc @fm3

@philippotto philippotto changed the title Enable animations for all users Enable video animations for all users Nov 24, 2023
@fm3
Copy link
Member

fm3 commented Nov 27, 2023

Yeah, makes sense. That is now tracked in #7458

@hotzenklotz hotzenklotz enabled auto-merge (squash) December 13, 2023 09:24
@hotzenklotz hotzenklotz disabled auto-merge December 13, 2023 12:10
@hotzenklotz hotzenklotz merged commit 9782945 into master Dec 13, 2023
@hotzenklotz hotzenklotz deleted the enable-animation branch December 13, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants