Use match shorthand DataLayerWithMagLocators.mapped

[fm3]

Also, codespell.

Steps to test:

• Compose dataset should still work (with at least one zarr or n5 or precomputed layer)

Issues:

• fixes Use DataLayerWithMagLocators.mapped instead of match cascades where possible #8299

---

• Considered common edge cases
• Needs datastore update after deployment

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request encompasses minor modifications across three files. In the frontend, a typographical error in a tooltip text was corrected. In the backend's ComposeService.scala, the data layer handling was streamlined by reducing import statements and introducing a new method for processing layers using DataLayerWithMagLocators.mapped. The changelog was also updated with consistent hyphenation for "double-clicking" terminology.

Changes

File	Change Summary
frontend/javascripts/oxalis/view/left-border-tabs/layer_settings_tab.tsx	Corrected tooltip text typo from "overriden" to "overridden"
webknossos-datastore/app/com/scalableminds/webknossos/datastore/services/uploading/ComposeService.scala	Simplified import statements and layer processing logic
CHANGELOG.released.md	Corrected hyphenation of "double-clicking" instances

Assessment against linked issues

Objective	Addressed	Explanation
Use DataLayerWithMagLocators.mapped [#8299]	✅

Possibly related PRs

• Allow selective segment visibility regardless of proofreading tool #8281: Selective Visibility feature implementation
• Call triggers/reload with fallback layer name #8298: Data reloading logic improvements
• Omit mag slider in TIFF export if only one mag is available #8297: User interface enhancements for TIFF exports
• Fix edge cases in NGFF dataset upload #8341: NGFF dataset upload edge case handling

Suggested labels

bug, frontend

Suggested reviewers

• frcroth

Poem

🐰 A rabbit's code review delight,
Typos fixed with scholarly might,
Imports trimmed, layers refined,
Precision in each line designed,
Coding magic takes its flight! 🔍

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5122623 and 2ebc5b7.

📒 Files selected for processing (1)

• CHANGELOG.released.md (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• CHANGELOG.released.md

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: circleci_build

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

webknossos-datastore/app/com/scalableminds/webknossos/datastore/services/uploading/ComposeService.scala (1)

95-97: Great refactoring using DataLayerWithMagLocators!

The consolidation of multiple layer types under DataLayerWithMagLocators reduces code duplication and improves maintainability. This pattern will make it easier to add new layer types in the future.

Consider evaluating if WKWDataLayer and WKWSegmentationLayer could also implement DataLayerWithMagLocators in the future to further unify the pattern.

CHANGELOG.unreleased.md (1)

23-23: Add hyphen in "auto-sorting".

For grammatical correctness, add a hyphen when using "auto" as part of a compound modifier.

-Enabled auto sorting of Typescript imports in Biome linter.
+Enabled auto-sorting of TypeScript imports in Biome linter.

Note: Also corrected the capitalization of "TypeScript" in the same line.

🧰 Tools

🪛 LanguageTool

[uncategorized] ~23-~23: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’).
Context: ...leminds/webknossos/pull/8314) - Enabled auto sorting of Typescript imports in Biome linter. ...

(AUTO_HYPHEN)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb1423c and 5122623.

📒 Files selected for processing (3)

• CHANGELOG.unreleased.md (1 hunks)
• frontend/javascripts/oxalis/view/left-border-tabs/layer_settings_tab.tsx (1 hunks)
• webknossos-datastore/app/com/scalableminds/webknossos/datastore/services/uploading/ComposeService.scala (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• frontend/javascripts/oxalis/view/left-border-tabs/layer_settings_tab.tsx

🧰 Additional context used

🪛 LanguageTool

CHANGELOG.unreleased.md

[uncategorized] ~23-~23: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’).
Context: ...leminds/webknossos/pull/8314) - Enabled auto sorting of Typescript imports in Biome linter. ...

(AUTO_HYPHEN)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: circleci_build

🔇 Additional comments (2)

webknossos-datastore/app/com/scalableminds/webknossos/datastore/services/uploading/ComposeService.scala (1)

5-5: LGTM! Good refactoring of imports.

The simplified imports reflect a move towards using the more generic DataLayerWithMagLocators pattern, reducing coupling to specific layer implementations.

CHANGELOG.unreleased.md (1)

19-19: LGTM! Consistent use of "double-click" terminology.

The hyphenated form "double-click" is correctly used across the changelog entries, following standard UI terminology conventions.

Also applies to: 25-25