-
Notifications
You must be signed in to change notification settings - Fork 29
In Unified Annotation Versioning migration, add option for using smaller batch sizes #8419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Warning Rate limit exceeded@fm3 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 2 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request introduces a new command-line option, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
tools/migration-unified-annotation-versioning/main.py
(1 hunks)tools/migration-unified-annotation-versioning/migration.py
(4 hunks)
🔇 Additional comments (5)
tools/migration-unified-annotation-versioning/main.py (1)
26-26
: Command-line option added for batch size control.This is a good addition that allows users to work around "too-large-request" errors by reducing batch sizes. The help text clearly explains when this option should be used.
tools/migration-unified-annotation-versioning/migration.py (4)
110-111
: Batch size reduced for fetching updates.Good implementation of the small batch sizes feature. When the flag is enabled, the batch size is reduced from 100 to 10, which should help with large request issues.
168-169
: Buffer size reduced for update migrations.Consistent with the implementation pattern, reducing the buffer size from 100 to 10 when small batch sizes are requested.
336-337
: Volume proto page size reduction.Significant reduction from 2000 to 100 when small batch sizes are enabled. This should help with memory pressure during large volume proto migrations.
445-453
: Segment index migration batch size configuration.The implementation defines batch size parameters at the beginning of the method and conditionally adjusts them based on the
small_batch_sizes
flag. This approach provides a clean separation of configuration from the actual migration logic.
Follow-up for #7917