Skip to content

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Mar 25, 2025

Got errors in task creation with a volume-only task type and volume base annotation supplied as zip during task creation. Turns out the dataSource lookup failed because we need to insert it into the annotationDataSourceTemporaryStore first in this case. This PR adds that.

URL of deployed dev instance (used for testing):

Steps to test:

  • Create volume-only annotation, download
  • Create volume task type
  • In task creation, upload this zip, select the task type
  • task should be creatable

Copy link
Contributor

coderabbitai bot commented Mar 25, 2025

📝 Walkthrough

Walkthrough

This pull request fixes a bug that caused task creation to fail when using a volume zip as input by adding a new entry to the changelog. It also updates several controllers and models to adjust the handling of the dataSource parameter. Changes include removing unnecessary option wrapping in parameters, adding a dependency for dataset services in task creation, and renaming parameters for clarity in the remote tracing store client. Method signatures across multiple classes in the task creation workflow have been updated to directly accept and validate a usable data source.

Changes

Files Change Summary
CHANGELOG.unreleased.md Added a new entry in the fixed section for a bug where task creation failed with volume zip input.
app/…/AnnotationIOController.scala, app/…/TaskController.scala Updated AnnotationIOController.scala to pass dataSource directly; modified TaskController.scala to include a new DatasetService dependency for retrieving a usable data source.
app/…/AnnotationService.scala, app/…/WKRemoteTracingStoreClient.scala Updated AnnotationService.scala to retrieve and pass a usable dataSource when saving volume tracing; renamed parameters and updated method signatures in WKRemoteTracingStoreClient.scala to handle dataSource directly.
app/…/TaskCreationService.scala Updated multiple method signatures to add a dataSource parameter, ensuring robust handling during task creation and tracing operations.

Possibly related PRs

  • scalableminds/webknossos#8405: The changes in the main PR are related to those in the retrieved PR as both involve modifications to how data sources are handled, specifically in the context of saving volume tracings and task creation, with a focus on the dataSource parameter.
  • scalableminds/webknossos#8350: The changes in the main PR, which involve modifications to how the dataSource parameter is handled in task creation and volume tracing, are related to the changes in the retrieved PR, which also focuses on managing data sources and paths, particularly in the context of dataset handling and storage.

Suggested labels

enhancement

Suggested reviewers

  • frcroth

Poem

I'm a rabbit hopping through a codey glade,
New data paths and fixes cheer my escapade.
Parameters now dance in a direct, clear line,
Bugs run off as every method shines.
I twirl with joy, a carrot in paw—code's looking fine!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb9729b and e2d3b72.

📒 Files selected for processing (3)
  • CHANGELOG.unreleased.md (1 hunks)
  • app/controllers/AnnotationIOController.scala (1 hunks)
  • app/models/task/TaskCreationService.scala (8 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • CHANGELOG.unreleased.md
  • app/controllers/AnnotationIOController.scala
  • app/models/task/TaskCreationService.scala
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: circleci_build

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fm3 fm3 self-assigned this Mar 25, 2025
@fm3 fm3 marked this pull request as ready for review March 25, 2025 15:07
@fm3 fm3 requested a review from MichaelBuessemeyer March 25, 2025 15:15
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome looks good and works 🎉
Thanks for fixing this 🙏

@fm3 fm3 enabled auto-merge (squash) March 26, 2025 10:17
@fm3 fm3 merged commit 38d92ac into master Mar 26, 2025
3 checks passed
@fm3 fm3 deleted the fix-creating-volume-tasks branch March 26, 2025 10:30
@coderabbitai coderabbitai bot mentioned this pull request Jul 30, 2025
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants