-
Notifications
You must be signed in to change notification settings - Fork 29
Fix creating volume tasks with base annotation #8468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis pull request fixes a bug that caused task creation to fail when using a volume zip as input by adding a new entry to the changelog. It also updates several controllers and models to adjust the handling of the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome looks good and works 🎉
Thanks for fixing this 🙏
Got errors in task creation with a volume-only task type and volume base annotation supplied as zip during task creation. Turns out the dataSource lookup failed because we need to insert it into the
annotationDataSourceTemporaryStore
first in this case. This PR adds that.URL of deployed dev instance (used for testing):
Steps to test: