-
Notifications
You must be signed in to change notification settings - Fork 29
Replace docker compose script in yarn #8541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
024e8f5
d377570
9f8c3d7
4cd010d
2ca953d
5dd8e54
594ca94
5a640cb
43530a8
4535599
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
#!/usr/bin/env bash | ||
|
||
# Start Docker | ||
export POSTGRES_URL=jdbc:postgresql://localhost:5434/webknossos | ||
export POSTGRES_USER="webknossos" | ||
export POSTGRES_PASSWORD="secret" | ||
|
||
cd .github || exit | ||
docker compose down -v | ||
docker compose up -d postgres fossildb | ||
cd .. || exit | ||
|
||
"$@" | ||
RESULT=$? | ||
|
||
cd .github || exit | ||
docker compose down -v | ||
cd .. || exit | ||
|
||
exit "$RESULT" |
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,16 @@ | ||||||||||||||
#!/usr/bin/env bash | ||||||||||||||
|
||||||||||||||
set -xe | ||||||||||||||
Comment on lines
+1
to
+3
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainEnhance shell strictness for safer execution -set -xe
+set -euxo pipefail
This hardens the script and surfaces issues early. 🏁 Script executed: #!/bin/bash
sed -n '1,200p' tools/refresh-screenshots.sh Length of output: 398 Enhance shell strictness for safer execution in tools/refresh-screenshots.sh - set -xe
+ set -euxo pipefail
This hardens the script and surfaces issues early. 📝 Committable suggestion
Suggested change
|
||||||||||||||
|
||||||||||||||
rm -rf frontend/javascripts/test/screenshots/** | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Fix globbing to reliably clear screenshots -rm -rf frontend/javascripts/test/screenshots/**
+rm -rf frontend/javascripts/test/screenshots/* Or explicitly enable recursive globbing at the top: shopt -s globstar Either ensures the directory is properly emptied. |
||||||||||||||
|
||||||||||||||
docker run --rm \ | ||||||||||||||
--pull "always" \ | ||||||||||||||
--env "URL=$URL" \ | ||||||||||||||
--env "WK_AUTH_TOKEN=$WK_AUTH_TOKEN" \ | ||||||||||||||
--env "BROWSERSTACK_USERNAME=$BROWSERSTACK_USERNAME" \ | ||||||||||||||
--env "BROWSERSTACK_ACCESS_KEY=$BROWSERSTACK_ACCESS_KEY" \ | ||||||||||||||
--workdir "/home/pptruser/webknossos" \ | ||||||||||||||
--volume ".:/home/pptruser/webknossos" \ | ||||||||||||||
--user "$(id -u):$(id -g)" \ | ||||||||||||||
scalableminds/puppeteer:master bash -c 'for i in {1..3}; do yarn test-screenshot && break; done' |
Uh oh!
There was an error while loading. Please reload this page.