-
Notifications
You must be signed in to change notification settings - Fork 29
Update DEV_INSTALL.md to mention new node version #8552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Required by changes introduced in #8479
📝 WalkthroughWalkthroughThe development installation documentation was updated to require Node.js version 22 instead of version 18. The Ubuntu installation instructions now use nvm to install Node.js 22, and the manual installation section specifies Node.js 22 or higher as the minimum requirement. The Node.js, sbt, Oracle JDK, and git download URLs were changed from HTTP to HTTPS links. No other installation steps or dependencies were modified. Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
DEV_INSTALL.md (1)
29-31
: 💡 Verification agent🧩 Analysis chain
Use secure HTTPS link for Node.js download
The dependency list currently points tohttp://nodejs.org/download/
. For consistency and security, switch to the HTTPS protocol and the canonical Node.js download page.Run this script to confirm there are no leftover references to the old HTTP link or version 18:
Apply this diff:
-* [node.js 22+](http://nodejs.org/download/) +* [node.js 22+](https://nodejs.org/)
🏁 Script executed:
#!/bin/bash # Verify no hardcoded HTTP or version 18 remains in DEV_INSTALL.md rg -nE "http://nodejs\.org|18" DEV_INSTALL.mdLength of output: 106
🏁 Script executed:
#!/bin/bash # Correctly verify no hardcoded HTTP link for Node.js or references to version 18 in DEV_INSTALL.md rg -n 'http://nodejs\.org/download|18' DEV_INSTALL.md || trueLength of output: 103
Use secure HTTPS link for Node.js download
The Node.js entry in DEV_INSTALL.md still points to an HTTP URL. Please update it to HTTPS for consistency and security.
• File: DEV_INSTALL.md
• Line: 30Apply this diff:
-* [node.js 22+](http://nodejs.org/download/) +* [node.js 22+](https://nodejs.org/)
🧹 Nitpick comments (1)
DEV_INSTALL.md (1)
137-138
: Use secure HTTPS link in manual installation section
The manual instructions still referencehttp://nodejs.org/
. Update to the secure URL for consistency.-* Install node from [http://nodejs.org/](http://nodejs.org/) +* Install node from [https://nodejs.org/](https://nodejs.org/)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
DEV_INSTALL.md
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build-smoketest-push
- GitHub Check: backend-tests
- GitHub Check: frontend-tests
🔇 Additional comments (1)
DEV_INSTALL.md (1)
85-90
: Ubuntu instructions updated for Node.js 22 via nvm
The snippet correctly replaces the previous Node.js 18 steps with:# Install nvm, node 22 curl -o- https://github.com/raw/nvm-sh/nvm/v0.39.7/install.sh | bash source ~/.bashrc nvm install 22 nvm use 22This aligns with the PR objective of requiring Node.js 22+.
You may also want to verify that nvm v0.39.7 is still the latest stable release and update the install script URL if necessary.
Required by changes introduced in #8479