Skip to content

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Apr 23, 2025

Required by changes introduced in #8479

@fm3 fm3 requested a review from philippotto April 23, 2025 09:23
@fm3 fm3 self-assigned this Apr 23, 2025
Copy link
Contributor

coderabbitai bot commented Apr 23, 2025

📝 Walkthrough

Walkthrough

The development installation documentation was updated to require Node.js version 22 instead of version 18. The Ubuntu installation instructions now use nvm to install Node.js 22, and the manual installation section specifies Node.js 22 or higher as the minimum requirement. The Node.js, sbt, Oracle JDK, and git download URLs were changed from HTTP to HTTPS links. No other installation steps or dependencies were modified.

Changes

File(s) Change Summary
DEV_INSTALL.md Updated Node.js version requirement from 18 to 22 in Ubuntu and manual installation sections; changed Node.js, sbt, JDK, and git URLs to HTTPS.

Possibly related PRs

Poem

Hopping along the install guide,
Node.js 22 is now our pride!
From eighteen we leap, with nvm in tow,
Fresh docs for devs, so onward we go.
The URLs are new, the steps are clear,
Happy coding, spring is here! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9848050 and f1e2e64.

📒 Files selected for processing (1)
  • DEV_INSTALL.md (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • DEV_INSTALL.md
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: build-smoketest-push
  • GitHub Check: backend-tests
  • GitHub Check: frontend-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fm3 fm3 enabled auto-merge (squash) April 23, 2025 09:25
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (1)
DEV_INSTALL.md (1)

29-31: 💡 Verification agent

🧩 Analysis chain

Use secure HTTPS link for Node.js download
The dependency list currently points to http://nodejs.org/download/. For consistency and security, switch to the HTTPS protocol and the canonical Node.js download page.

Run this script to confirm there are no leftover references to the old HTTP link or version 18:

Apply this diff:

-* [node.js 22+](http://nodejs.org/download/)
+* [node.js 22+](https://nodejs.org/)

🏁 Script executed:

#!/bin/bash
# Verify no hardcoded HTTP or version 18 remains in DEV_INSTALL.md
rg -nE "http://nodejs\.org|18" DEV_INSTALL.md

Length of output: 106


🏁 Script executed:

#!/bin/bash
# Correctly verify no hardcoded HTTP link for Node.js or references to version 18 in DEV_INSTALL.md
rg -n 'http://nodejs\.org/download|18' DEV_INSTALL.md || true

Length of output: 103


Use secure HTTPS link for Node.js download

The Node.js entry in DEV_INSTALL.md still points to an HTTP URL. Please update it to HTTPS for consistency and security.

• File: DEV_INSTALL.md
• Line: 30

Apply this diff:

-* [node.js 22+](http://nodejs.org/download/)
+* [node.js 22+](https://nodejs.org/)
🧹 Nitpick comments (1)
DEV_INSTALL.md (1)

137-138: Use secure HTTPS link in manual installation section
The manual instructions still reference http://nodejs.org/. Update to the secure URL for consistency.

-* Install node from [http://nodejs.org/](http://nodejs.org/)
+* Install node from [https://nodejs.org/](https://nodejs.org/)
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3dd2a8 and 9848050.

📒 Files selected for processing (1)
  • DEV_INSTALL.md (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: build-smoketest-push
  • GitHub Check: backend-tests
  • GitHub Check: frontend-tests
🔇 Additional comments (1)
DEV_INSTALL.md (1)

85-90: Ubuntu instructions updated for Node.js 22 via nvm
The snippet correctly replaces the previous Node.js 18 steps with:

# Install nvm, node 22
curl -o- https://github.com/raw/nvm-sh/nvm/v0.39.7/install.sh | bash
source ~/.bashrc
nvm install 22
nvm use 22

This aligns with the PR objective of requiring Node.js 22+.
You may also want to verify that nvm v0.39.7 is still the latest stable release and update the install script URL if necessary.

@fm3 fm3 merged commit 9d29497 into master Apr 23, 2025
5 checks passed
@fm3 fm3 deleted the fm3-patch-1 branch April 23, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants