-
Notifications
You must be signed in to change notification settings - Fork 29
Pass sharingToken to dataset name disambiguation logic #8625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 Walkthrough## Walkthrough
This change updates both backend and frontend logic to support accessing datasets with legacy-style links lacking IDs by using an optional sharing token. Controller methods, API routes, and frontend calls now accept and forward this token, enabling context-aware dataset retrieval via a sharing token provided in the URL.
## Changes
| Files/Paths | Change Summary |
|---------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------|
| app/controllers/DatasetController.scala, conf/webknossos.latest.routes | Controller methods and corresponding routes updated to accept an optional `sharingToken` parameter for context-aware dataset lookup. |
| frontend/javascripts/admin/api/disambiguate_legacy_routes.tsx | API function `getOrganizationForDataset` updated to accept and forward an optional `sharingToken` as a query parameter. |
| frontend/javascripts/router.tsx | Route handlers extract `token` from URL query parameters and pass it to relevant API calls for dataset disambiguation and access. |
| CHANGELOG.unreleased.md | Changelog entry added describing the fix for legacy-style dataset links using sharing tokens. |
## Possibly related PRs
- scalableminds/webknossos#8242: Modifies organization lookup in dataset read methods to use a global access context, similar to this PR's context-aware dataset retrieval using a sharing token.
## Suggested labels
`frontend`
## Suggested reviewers
- normanrz
## Poem
> A rabbit hopped through legacy fields,
> Where old dataset links had hidden yields.
> With a sharing token now in paw,
> It found the data—hip, hip, hurrah!
> Through backend and frontend, the path was made clear,
> So all could access, without any fear.
> 🐇✨ Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here: Looks good and works well. Thanks for fixing this 🙏
* Pass sharingToken to dataset name disambiguation logic * changelog * empty commit
* Release 25.05.0 * Pass sharingToken to dataset name disambiguation logic (#8625) * Pass sharingToken to dataset name disambiguation logic * changelog * empty commit * Update CHANGELOG.released.md Co-authored-by: Philipp Otto <[email protected]> --------- Co-authored-by: Philipp Otto <[email protected]> Co-authored-by: Philipp Otto <[email protected]>
#8075 introduced disambiguation routes that are used when opening legacy-style links. However, links with sharingToken did not forward this sharingToken to these routes, so that they fail if the sharingToken is strictly necessary to access the dataset.
This PR adds passes the token in this case.
Thanks to @MichaelBuessemeyer for the help with the frontend parameters :)
URL of deployed dev instance (used for testing):
Steps to test:
Issues: