Skip to content

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented May 20, 2025

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • create a new volume tracing with no fallback (that we definitely have a segment index)
  • brush a bit
  • ensure that segments tab is NOT visible
  • reload the page
  • rightclick a segment -> the segment stats should show (on the master, this did not happen)

Explanation

The information whether a segmentation layer has a segment index is loaded ad-hoc. If the segments tab is visible, this is done on mount. If not, it only happens as soon as the context menu is loaded. However, the react hook did not update when the information about the segment index changed. This is fixed now.

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this May 20, 2025
Copy link
Contributor

coderabbitai bot commented May 20, 2025

📝 Walkthrough

Walkthrough

A changelog entry was added to document a fix for segment statistics not displaying in the context menu. In the frontend code, the dependency array for a data-fetching hook in the context menu component was updated to include segment index availability, ensuring segment stats are fetched appropriately.

Changes

Files/Paths Change Summary
CHANGELOG.unreleased.md Added a line in the "Fixed" section documenting the segment statistics context menu display issue.
frontend/javascripts/viewer/view/context_menu.tsx Expanded the dependency array for the useFetch hook to include isSegmentIndexAvailable.

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Fix initial context menu not fetching segment stats (#8470)

Suggested labels

bug, frontend

Poem

A fix for stats that hid from view,
Now fetches right when first you do!
No more clicks required twice,
Segment info fetched precise.
The changelog notes this happy feat—
Bugs retreat, and code is neat!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1c737d0 and 7625bb3.

📒 Files selected for processing (2)
  • CHANGELOG.unreleased.md (1 hunks)
  • frontend/javascripts/viewer/view/context_menu.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: build-smoketest-push
  • GitHub Check: backend-tests
  • GitHub Check: frontend-tests
🔇 Additional comments (2)
CHANGELOG.unreleased.md (1)

45-45: Well-documented fix in the changelog.

The changelog entry correctly describes the issue that was fixed in the PR, providing good context for users and maintainers about what problem was resolved.

frontend/javascripts/viewer/view/context_menu.tsx (1)

1602-1607: Great fix for segment stats display issue.

Adding isSegmentIndexAvailable to the dependency array ensures that the useFetch hook re-runs when the segment index availability changes. This fixes the core issue where segment statistics weren't appearing on the first opening of the context menu when the segments tab wasn't initially visible.

The hook will now properly react to the segment index becoming available after the component is mounted, ensuring that segment statistics are displayed correctly on first open.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, the fix works. And is also very minimal and elegant 🎉

Thanks for fixing this 🙏

@philippotto philippotto merged commit 0bcb244 into master May 21, 2025
5 checks passed
@philippotto philippotto deleted the fix-segment-stats-on-first-context-menu branch May 21, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

First right-click after pageload does not fetch segment stats

2 participants