-
Notifications
You must be signed in to change notification settings - Fork 29
Replace withRouter HOC with useHistory hook #8721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis update refactors several React components to replace the use of the Changes
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (7)
|
withRouter
HOC with useHistory
hook
withRouter
HOC with useHistory
hookThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, lgtm 👍 by the way, I usually don't create changelog entries for changes that are only implementation-specific, because external users won't really care about them, I assume.
Small PR to refactor some technical debt in our React stack. I replaced the
withRouter
HOC fromreact-router
with auseHistory
hook instead.The remaining 6 files with
withRouter
still use React class components.Issues:
(Please delete unneeded items, merge only when none are left open)
$PR_NUMBER.md
file inunreleased_changes
or use./tools/create-changelog-entry.py
)