Skip to content

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Jul 10, 2025

URL of deployed dev instance (used for testing):

  • Support non-WKW layers for linking upon upload

Steps to test:

import webknossos as wk
import numpy as np

ds = wk.Dataset("test", (1,1,1))
ds.write_layer("raw", wk.COLOR_CATEGORY, data=np.zeros((2,2)))
ds.upload(layers_to_link=[wk.Dataset.open_remote("http://localhost:9000/datasets/l4_sample").get_layer("color")]

(Please delete unneeded items, merge only when none are left open)

  • Added changelog entry (create a $PR_NUMBER.md file in unreleased_changes or use ./tools/create-changelog-entry.py)

Copy link
Contributor

coderabbitai bot commented Jul 10, 2025

📝 Walkthrough

Walkthrough

The update expands the range of supported layer types in the layerFromIdentifier method within the upload service, enabling it to handle additional data and segmentation layer classes. Import statements are consolidated and broadened to include all relevant layer types from the dataformats.layers package. No public API signatures are changed.

Changes

File Path Change Summary
webknossos-datastore/app/com/scalableminds/webknossos/datastore/services/uploading/UploadService.scala Expanded imports to include all layer types; updated pattern matching in layerFromIdentifier to support more layer classes including N5, Precomputed, Zarr, and WKW layers.

Suggested labels

backend

Suggested reviewers

  • fm3

Poem

A warren of layers, now more complete,
With Zarr and N5, the code skips a beat.
Segmentation and data, all join the dance,
In the upload service, they now get a chance.
🐇 Hopping through code, with imports anew—
More layers to link, more work to do!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a0bedf and 0cc1839.

📒 Files selected for processing (1)
  • unreleased_changes/8773.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • unreleased_changes/8773.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build-smoketest-push
  • GitHub Check: backend-tests
  • GitHub Check: frontend-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@normanrz normanrz self-assigned this Jul 10, 2025
@normanrz normanrz requested a review from fm3 July 10, 2025 11:03
@normanrz normanrz enabled auto-merge (squash) July 10, 2025 11:52
@normanrz normanrz merged commit 1562965 into master Jul 10, 2025
5 checks passed
@normanrz normanrz deleted the link-layers-zarr branch July 10, 2025 12:01
@coderabbitai coderabbitai bot mentioned this pull request Oct 8, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants