Fix moving dashboard folders

[fm3]

Fixes regression from #8372

URL of deployed dev instance (used for testing):

• https://movefolders.webknossos.xyz

Steps to test:

• Create a couple of folders in dashboard
• Move them into each other, should work and not error

Issues:

• fixes [Dashboard] Folder drag and drop causes SQL bug #8777

---

• Added changelog entry (create a $PR_NUMBER.md file in unreleased_changes or use ./tools/create-changelog-entry.py)
• Considered common edge cases

[coderabbitai]

📝 Walkthrough

Walkthrough

A validation was added to prevent moving a folder into itself, with a corresponding error message. The SQL logic for deleting obsolete folder paths during subtree moves was corrected to avoid unique constraint violations. Documentation and message files were updated to reflect these changes and the resolved bug.

Changes

File(s)	Change Summary
app/controllers/FolderController.scala	Added validation in the move method to prevent moving a folder into itself.
app/models/folder/Folder.scala	Corrected SQL query in moveSubtree to fix folder path deletion logic during subtree moves.
conf/messages	Added new error message: folder.move.self=Cannot move a folder into itself.
unreleased_changes/8793.md	Added changelog entry describing the bug fix for folder move SQL errors.

Estimated code review effort

2 (~15 minutes)

Poem

🗂️
A folder tried to move itself—
The code said, “No, my little elf!”
Paths now tidy, bugs are gone,
No more errors linger on.
SQL’s happy, folders cheer,
Dashboard moves are crystal clear!
—🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 91e81ee and c4fe713.

📒 Files selected for processing (4)

• app/controllers/FolderController.scala (1 hunks)
• app/models/folder/Folder.scala (1 hunks)
• conf/messages (1 hunks)
• unreleased_changes/8793.md (1 hunks)

🧬 Code Graph Analysis (1)

app/controllers/FolderController.scala (1)

util/src/main/scala/com/scalableminds/util/tools/Fox.scala (3)

• Fox (30-223)
• Fox (225-289)
• fromBool (32-36)

🧰 Additional context used

🧬 Code Graph Analysis (1)

app/controllers/FolderController.scala (1)

util/src/main/scala/com/scalableminds/util/tools/Fox.scala (3)

• Fox (30-223)
• Fox (225-289)
• fromBool (32-36)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: frontend-tests
• GitHub Check: backend-tests
• GitHub Check: build-smoketest-push

🔇 Additional comments (3)

conf/messages (1)

374-374: LGTM!

The error message is clear and follows the existing naming convention for folder-related messages.

unreleased_changes/8793.md (1)

1-2: LGTM!

The changelog entry clearly describes the bug fix.

app/models/folder/Folder.scala (1)

320-326: Fix correctly addresses the SQL error in folder moves

The change from fp2._descendant = fp1._descendant to fp2._descendant = fp1._ancestor properly identifies obsolete folder paths to delete. This ensures that only paths that are no longer valid after the move are removed, preventing the unique constraint violations that were causing the SQL errors.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.