Include a remote dataset in the dev setup initial data #8891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b721d24.
full datasource validation now also runs when reading datasource-properties.jsons from disk. The result is shown in the dashboard on “show error”. The same validation also runs in the reserveManualUpload route This also fixes a regression from #8844 where you could no longer hit reload on unusable datasets. It has, however, been slightly relaxed (no more path checks as those have been moved elsewhere in #8844 ) ### Steps to test: - Edit datasource on disk, making it invalid (e.g. introduce duplicate layer names or mags) ### Issues: - fixes https://scm.slack.com/archives/CMBMU5684/p1747643139269819 ------ - [x] Added changelog entry (create a `$PR_NUMBER.md` file in `unreleased_changes` or use `./tools/create-changelog-entry.py`) - [x] Considered [common edge cases](../blob/master/.github/common_edge_cases.md) - [x] Needs datastore update after deployment
fm3
requested review from
MichaelBuessemeyer
and removed request for
frcroth
MichaelBuessemeyer
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on and thus blocked by #8844
Steps to test:
Issues
$PR_NUMBER.mdfile inunreleased_changesor use./tools/create-changelog-entry.py)