Skip to content

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Sep 22, 2025

  • Added changelog entry

@fm3 fm3 self-assigned this Sep 22, 2025
@fm3 fm3 marked this pull request as ready for review September 22, 2025 07:51
Copy link
Contributor

coderabbitai bot commented Sep 22, 2025

📝 Walkthrough

Walkthrough

Adds 25.10.0 sections to released changelog and migrations, adjusts an older migration entry’s placement/formatting, and removes corresponding unreleased changelog notes across multiple files.

Changes

Cohort / File(s) Summary of Changes
Released changelog
CHANGELOG.released.md
Added 25.10.0 release notes covering new features, changes, and fixes.
Released migrations
MIGRATIONS.released.md
Added evolutions 139 and 140 to 25.10.0; adjusted visibility/order of 138 within 25.09.0; fixed minor formatting/newline in 012 entry.
Unreleased changelog cleanup
unreleased_changes/* (8796, 8824, 8850, 8865, 8876, 8882, 8885, 8888, 8895, 8896, 8901, 8903, 8909, 8911, 8915, 8919, 8925, 8926, 8927)
Removed “Added/Changed/Fixed” notes now reflected in released changelog/migrations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • philippotto
  • normanrz

Poem

I thump my paw—release is nigh,
Notes hop from “unreleased” to the sky.
Migrations lined in tidy rows,
The burrow’s ledger calmly grows.
With nib and carrot, I declare:
25.10.0—handled with care. 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Prepare Release 25.10.0" is concise, clearly states the PR's primary purpose (release preparation and changelog additions), and accurately reflects the changes in the diff so a reviewer scanning history will understand the intent.
Description Check ✅ Passed The description "- [x] Added changelog entry" is directly related to the changes in the PR and meets the lenient requirement that the description be on-topic.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch prepare-release-25.10.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fm3 fm3 requested a review from normanrz September 22, 2025 07:52
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
CHANGELOG.released.md (2)

23-26: Small grammar fix in “Changed” entry.

Swap word order for clarity.

- The webknossos-worker jobs export_tiff and render_animation are now allowed also for public datasets of other organizations. [#8911](https://github.com/scalableminds/webknossos/pull/8911)
+ The webknossos-worker jobs export_tiff and render_animation are now also allowed for public datasets of other organizations. [#8911](https://github.com/scalableminds/webknossos/pull/8911)

31-36: Consistency/polish: unify tense (“Fixed”), add commas, and end with periods.

Align with house style in this section.

- Fixed that pressing AltGr, Ctrl or Command closed the authentication modal when viewing a public dataset. [#8895](https://github.com/scalableminds/webknossos/pull/8895)
+ Fixed that pressing AltGr, Ctrl, or Command closed the authentication modal when viewing a public dataset. [#8895](https://github.com/scalableminds/webknossos/pull/8895)

- Ad hoc mesh requests loading infinitely. [#8915](https://github.com/scalableminds/webknossos/pull/8915)
+ Fixed that ad hoc mesh requests could load indefinitely. [#8915](https://github.com/scalableminds/webknossos/pull/8915)

- Fix periodic polling of missing updates when another user edits an annotation. [#8919](https://github.com/scalableminds/webknossos/pull/8919)
+ Fixed periodic polling of missing updates when another user edits an annotation. [#8919](https://github.com/scalableminds/webknossos/pull/8919)

- Fixed a bug in reading zarr3-format connectome files caused by a wrong metadata key [#8927](https://github.com/scalableminds/webknossos/pull/8927)
+ Fixed a bug in reading zarr3-format connectome files caused by an incorrect metadata key. [#8927](https://github.com/scalableminds/webknossos/pull/8927)

Also applies to: 40-40

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b12883 and 4a1d123.

📒 Files selected for processing (21)
  • CHANGELOG.released.md (1 hunks)
  • MIGRATIONS.released.md (2 hunks)
  • unreleased_changes/8796.md (0 hunks)
  • unreleased_changes/8824.md (0 hunks)
  • unreleased_changes/8850.md (0 hunks)
  • unreleased_changes/8865.md (0 hunks)
  • unreleased_changes/8876.md (0 hunks)
  • unreleased_changes/8882.md (0 hunks)
  • unreleased_changes/8885.md (0 hunks)
  • unreleased_changes/8888.md (0 hunks)
  • unreleased_changes/8895.md (0 hunks)
  • unreleased_changes/8896.md (0 hunks)
  • unreleased_changes/8901.md (0 hunks)
  • unreleased_changes/8903.md (0 hunks)
  • unreleased_changes/8909.md (0 hunks)
  • unreleased_changes/8911.md (0 hunks)
  • unreleased_changes/8915.md (0 hunks)
  • unreleased_changes/8919.md (0 hunks)
  • unreleased_changes/8925.md (0 hunks)
  • unreleased_changes/8926.md (0 hunks)
  • unreleased_changes/8927.md (0 hunks)
💤 Files with no reviewable changes (19)
  • unreleased_changes/8895.md
  • unreleased_changes/8850.md
  • unreleased_changes/8888.md
  • unreleased_changes/8882.md
  • unreleased_changes/8927.md
  • unreleased_changes/8903.md
  • unreleased_changes/8896.md
  • unreleased_changes/8909.md
  • unreleased_changes/8901.md
  • unreleased_changes/8925.md
  • unreleased_changes/8876.md
  • unreleased_changes/8885.md
  • unreleased_changes/8915.md
  • unreleased_changes/8911.md
  • unreleased_changes/8824.md
  • unreleased_changes/8926.md
  • unreleased_changes/8796.md
  • unreleased_changes/8919.md
  • unreleased_changes/8865.md
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: MichaelBuessemeyer
PR: scalableminds/webknossos#8221
File: CHANGELOG.unreleased.md:14-14
Timestamp: 2024-11-25T14:52:23.201Z
Learning: For the `webknossos` project, changelog entries in `CHANGELOG.unreleased.md` should be concise and avoid unnecessary detailed explanations.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build-smoketest-push
  • GitHub Check: frontend-tests
  • GitHub Check: backend-tests
🔇 Additional comments (4)
MIGRATIONS.released.md (3)

22-22: Placement of 138-add-webauthn-credentials under 25.09.0 is appropriate.

Ordering now reads 136, 137, 138 for 25.09.0. Good.


901-901: Minor formatting/newline fix LGTM.

Consistent list formatting at file end.


9-15: Remove entries from MIGRATIONS.unreleased.md and push the 25.10.0 tag

Both SQL files exist (conf/evolutions/139-logout-everywhere.sql and conf/evolutions/140-annotation-layer-name-check-deferrable.sql) but they are still listed in MIGRATIONS.unreleased.md (lines 13–14); remove those entries and push the 25.10.0 tag/release so the compare link resolves.

CHANGELOG.released.md (1)

10-12: Confirm tag/compare links resolve before merging.

Verify that tag 25.10.0 exists and the compare link 25.09.0...25.10.0 renders correctly after tagging.

@fm3 fm3 enabled auto-merge (squash) September 22, 2025 08:10
@fm3 fm3 merged commit 75444fc into master Sep 22, 2025
5 checks passed
@fm3 fm3 deleted the prepare-release-25.10.0 branch September 22, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants