-
Notifications
You must be signed in to change notification settings - Fork 29
Prepare Release 25.10.0 #8937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Release 25.10.0 #8937
Conversation
fm3
commented
Sep 22, 2025
- Added changelog entry
📝 WalkthroughWalkthroughAdds 25.10.0 sections to released changelog and migrations, adjusts an older migration entry’s placement/formatting, and removes corresponding unreleased changelog notes across multiple files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CHANGELOG.released.md (2)
23-26
: Small grammar fix in “Changed” entry.Swap word order for clarity.
- The webknossos-worker jobs export_tiff and render_animation are now allowed also for public datasets of other organizations. [#8911](https://github.com/scalableminds/webknossos/pull/8911) + The webknossos-worker jobs export_tiff and render_animation are now also allowed for public datasets of other organizations. [#8911](https://github.com/scalableminds/webknossos/pull/8911)
31-36
: Consistency/polish: unify tense (“Fixed”), add commas, and end with periods.Align with house style in this section.
- Fixed that pressing AltGr, Ctrl or Command closed the authentication modal when viewing a public dataset. [#8895](https://github.com/scalableminds/webknossos/pull/8895) + Fixed that pressing AltGr, Ctrl, or Command closed the authentication modal when viewing a public dataset. [#8895](https://github.com/scalableminds/webknossos/pull/8895) - Ad hoc mesh requests loading infinitely. [#8915](https://github.com/scalableminds/webknossos/pull/8915) + Fixed that ad hoc mesh requests could load indefinitely. [#8915](https://github.com/scalableminds/webknossos/pull/8915) - Fix periodic polling of missing updates when another user edits an annotation. [#8919](https://github.com/scalableminds/webknossos/pull/8919) + Fixed periodic polling of missing updates when another user edits an annotation. [#8919](https://github.com/scalableminds/webknossos/pull/8919) - Fixed a bug in reading zarr3-format connectome files caused by a wrong metadata key [#8927](https://github.com/scalableminds/webknossos/pull/8927) + Fixed a bug in reading zarr3-format connectome files caused by an incorrect metadata key. [#8927](https://github.com/scalableminds/webknossos/pull/8927)Also applies to: 40-40
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (21)
CHANGELOG.released.md
(1 hunks)MIGRATIONS.released.md
(2 hunks)unreleased_changes/8796.md
(0 hunks)unreleased_changes/8824.md
(0 hunks)unreleased_changes/8850.md
(0 hunks)unreleased_changes/8865.md
(0 hunks)unreleased_changes/8876.md
(0 hunks)unreleased_changes/8882.md
(0 hunks)unreleased_changes/8885.md
(0 hunks)unreleased_changes/8888.md
(0 hunks)unreleased_changes/8895.md
(0 hunks)unreleased_changes/8896.md
(0 hunks)unreleased_changes/8901.md
(0 hunks)unreleased_changes/8903.md
(0 hunks)unreleased_changes/8909.md
(0 hunks)unreleased_changes/8911.md
(0 hunks)unreleased_changes/8915.md
(0 hunks)unreleased_changes/8919.md
(0 hunks)unreleased_changes/8925.md
(0 hunks)unreleased_changes/8926.md
(0 hunks)unreleased_changes/8927.md
(0 hunks)
💤 Files with no reviewable changes (19)
- unreleased_changes/8895.md
- unreleased_changes/8850.md
- unreleased_changes/8888.md
- unreleased_changes/8882.md
- unreleased_changes/8927.md
- unreleased_changes/8903.md
- unreleased_changes/8896.md
- unreleased_changes/8909.md
- unreleased_changes/8901.md
- unreleased_changes/8925.md
- unreleased_changes/8876.md
- unreleased_changes/8885.md
- unreleased_changes/8915.md
- unreleased_changes/8911.md
- unreleased_changes/8824.md
- unreleased_changes/8926.md
- unreleased_changes/8796.md
- unreleased_changes/8919.md
- unreleased_changes/8865.md
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: MichaelBuessemeyer
PR: scalableminds/webknossos#8221
File: CHANGELOG.unreleased.md:14-14
Timestamp: 2024-11-25T14:52:23.201Z
Learning: For the `webknossos` project, changelog entries in `CHANGELOG.unreleased.md` should be concise and avoid unnecessary detailed explanations.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build-smoketest-push
- GitHub Check: frontend-tests
- GitHub Check: backend-tests
🔇 Additional comments (4)
MIGRATIONS.released.md (3)
22-22
: Placement of 138-add-webauthn-credentials under 25.09.0 is appropriate.Ordering now reads 136, 137, 138 for 25.09.0. Good.
901-901
: Minor formatting/newline fix LGTM.Consistent list formatting at file end.
9-15
: Remove entries from MIGRATIONS.unreleased.md and push the 25.10.0 tagBoth SQL files exist (conf/evolutions/139-logout-everywhere.sql and conf/evolutions/140-annotation-layer-name-check-deferrable.sql) but they are still listed in MIGRATIONS.unreleased.md (lines 13–14); remove those entries and push the 25.10.0 tag/release so the compare link resolves.
CHANGELOG.released.md (1)
10-12
: Confirm tag/compare links resolve before merging.Verify that tag 25.10.0 exists and the compare link 25.09.0...25.10.0 renders correctly after tagging.