Skip to content

Compatibility jasync-sql 2.1.9+ #381

Closed
@KevinAtSesam

Description

@KevinAtSesam

With the later updates of jasync-sql, there was a bug that could be triggered by changing the settings using scalikejdbc-async 0.16.0. I made an issue related to this, but it also means that you'll have to look at the changes to keep your project compatible:

jasync-sql/jasync-sql#359

Activity

oshai

oshai commented on Jan 18, 2023

@oshai

As a workaround the issue (or more accurate to avoid it in the future) I suggest to replace Configuration.copy() call with Configuration.copyConfiguration().
I created a PR here: jasync-sql/jasync-sql#362 and would like to know if that something that seems reasonable to change here.
I also opened a suggestion to change that in kotlin language here: https://youtrack.jetbrains.com/issue/KT-56022/Support-JvmOverload-for-data-class-copy-function

oshai

oshai commented on Jan 29, 2023

@oshai

Looks like the issue with copy is in the class JasyncConfiguration.scala.
I created a PR that might fix it here: jasync-sql/jasync-sql#377

Regardless, publishing a version of scalikejdbc with latest jasync will solve it.

oshai

oshai commented on Jan 30, 2023

@oshai

@seratch are there any plans to release a new version? it should solve the issue.

seratch

seratch commented on Apr 17, 2023

@seratch
Member

Sorry for my slow response here, I just released a new version: https://github.com/scalikejdbc/scalikejdbc-async/releases/tag/0.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

dependenciesPull requests that update a dependency file

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @seratch@oshai@KevinAtSesam

      Issue actions

        Compatibility jasync-sql 2.1.9+ · Issue #381 · scalikejdbc/scalikejdbc-async