Skip to content

Conversation

francoisferrand
Copy link
Contributor

In order to ensure backbeat (and internal processes in general) are not affected by user's bucket policies, allow starting cloudserver with a separate "internal" port, through which bucket policies are currently bypassed.

More details here: https://scality.atlassian.net/wiki/spaces/OS/pages/2895347722/Authorizing+Internal+Services+S3+Operations

Issue: CLDSRV-650

This is used to handle internal traffic (esp. from backbeat) with
specific handling of policies where needed.

Issue: CLDSRV-650
@bert-e
Copy link
Contributor

bert-e commented May 26, 2025

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

Copy link
Contributor

@williamlardier williamlardier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Currently, bucket policies affect also internal processes (backbeat...),
which can allow end users to "break" some features (replication,
lifecycle...).

The topic was discussed in [1], and the short term solution is to use
some sort of "internal" cloudserver, which would not evaluate bucket
policies.

This is addressed by this commit, which adds the ability to create an
"internal" endpoint on a separate port, where bucket policies are
ignored.

[1] https://scality.atlassian.net/wiki/spaces/OS/pages/2895347722/Authorizing+Internal+Services+S3+Operations

Issue: CLDSRV-650
@francoisferrand francoisferrand force-pushed the improvement/CLDSRV-650 branch from 2796a6c to dfe7321 Compare May 26, 2025 08:50
Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.76%. Comparing base (0d150e9) to head (6d0c57c).
Report is 3 commits behind head on development/9.0.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/server.js 95.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/Config.js 78.06% <100.00%> (+0.85%) ⬆️
lib/api/apiUtils/authorization/permissionChecks.js 87.68% <100.00%> (ø)
lib/server.js 78.08% <95.00%> (+4.12%) ⬆️

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.0    #5807      +/-   ##
===================================================
+ Coverage            75.62%   75.76%   +0.13%     
===================================================
  Files                  188      188              
  Lines                11949    11963      +14     
===================================================
+ Hits                  9037     9064      +27     
+ Misses                2912     2899      -13     
Flag Coverage Δ
ceph-backend-test 46.88% <67.85%> (+0.01%) ⬆️
file-ft-tests 47.26% <64.28%> (+0.01%) ⬆️
kmip-ft-tests 26.75% <64.28%> (+<0.01%) ⬆️
mongo-v0-ft-tests 47.69% <64.28%> (+0.01%) ⬆️
mongo-v1-ft-tests 47.71% <64.28%> (+0.01%) ⬆️
multiple-backend 35.42% <67.85%> (+0.02%) ⬆️
quota-tests 32.15% <64.28%> (-0.88%) ⬇️
quota-tests-inflights 34.14% <64.28%> (+0.03%) ⬆️
unit 66.78% <89.28%> (+1.14%) ⬆️
utapi-v2-tests 33.25% <64.28%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@scality scality deleted a comment from bert-e May 26, 2025
@bert-e
Copy link
Contributor

bert-e commented May 26, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@francoisferrand
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented May 26, 2025

Build failed

The build for commit did not succeed in branch w/9.1/improvement/CLDSRV-650

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 26, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.0

  • ✔️ development/9.1

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

Please check the status of the associated issue CLDSRV-650.

Goodbye francoisferrand.

The following options are set: approve

@bert-e bert-e merged commit 6d0c57c into development/9.0 May 26, 2025
19 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-650 branch May 26, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants