Skip to content

Add primitive exclusive start key support to Table and SecondaryIndex #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2023
Merged

Add primitive exclusive start key support to Table and SecondaryIndex #1639

merged 1 commit into from
Apr 25, 2023

Conversation

jakobmerrild
Copy link
Contributor

Solves: #1638

@kailuowang kailuowang merged commit c4c91d0 into scanamo:master Apr 25, 2023
@jakobmerrild jakobmerrild deleted the add-from-overload-with-simple-dynamo-object branch April 25, 2023 21:14
@jakobmerrild
Copy link
Contributor Author

@kailuowang Thanks for accepting this. We're currently using the workaround mentioned in the issue. However, we would of course prefer to be able to use this new part of the API. Are you planning a version bump in the near future?

@jakobmerrild
Copy link
Contributor Author

I can see that I missed it by a minute 😅

@kailuowang
Copy link
Contributor

I just kicked off a new release.

@jakobmerrild
Copy link
Contributor Author

@kailuowang Thanks for the swift response. I'm not familiar with releasing libraries. I can see that there's a GitHub release with the new tag, but the artifacts are not on Maven/Scaladex, is there usually a delay or did something perhaps go wrong in the pipeline?

@kailuowang
Copy link
Contributor

hmm, my bad. I didn't realize that the release failed due to doc error on Scala 3

exception caught when loading trait Builder: Cyclic reference involving object KeysAndAttributes
exception caught when loading module class KeysAndAttributes$: Cyclic reference involving object KeysAndAttributes
Cyclic reference involving object KeysAndAttributes while compiling /home/runner/work/***/***/***/target/scala-3.2.2/classes/org/***/ConditionNotMet.tasty,

I think it's related to the change you added. Would you kindly debug it?

sbt  "++ 3.2.2 doc"

should give you the error.

@jakobmerrild
Copy link
Contributor Author

I'll have a look 👍

@jakobmerrild
Copy link
Contributor Author

As far as I can tell the command fails from this commit: e739d20

@jakobmerrild
Copy link
Contributor Author

jakobmerrild commented May 3, 2023 •
edited
Loading

Reverting e739d20 and running

sbt "++ 3.2.0 doc"

works fine. So I'm not sure the failure is related to my changes. Let me know if I can help more 🙂

@kailuowang
Copy link
Contributor

kailuowang commented May 3, 2023 via email

@kailuowang
Copy link
Contributor

Once #1643 is merged, I will re-release M25

@jakobmerrild
Copy link
Contributor Author

Thanks!

@kailuowang
Copy link
Contributor

released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailuowang kailuowang kailuowang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakobmerrild @kailuowang