Skip to content

some error messages aren't translated #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
piermariacosina opened this issue Jun 27, 2014 · 4 comments
Closed

some error messages aren't translated #19

piermariacosina opened this issue Jun 27, 2014 · 4 comments

Comments

@piermariacosina
Copy link

the cause for this is that in some messages there is a part that varies based on what I've inputed

"The username portion of the email address is invalid (the portion before the @: ùà)"

when this is tested againt the array of solutions && $.ajaxChimp.responses[msg]
returns always undefine
i've made a workaround cutting the part of the message that change.
msg = msg.substring(0,msg.indexOf("(")-1);
so the message become something like
"The username portion of the email address is invalid"

i think there is a better solution anyway

@scdoshi
Copy link
Owner

scdoshi commented Jul 18, 2014

We can do this using regular expressions.

@boshtian
Copy link

I also came across this issue and I've solved it with a check if there is colon in msg, since the two messages who have the colon are the only ones which have the user input in response.

If you'd like I can make a pull request with my solution.

@scdoshi
Copy link
Owner

scdoshi commented Sep 14, 2014

That would be great, thanks

On Sun, Sep 14, 2014 at 10:58 AM, Bostjan [email protected] wrote:

I also came across this issue and I've solved it with a check if there is
colon in msg, since the two messages who have the colon are the only ones
which have the user input in response.

If you'd like I can make a pull request with my solution.


Reply to this email directly or view it on GitHub
#19 (comment)
.

@scdoshi
Copy link
Owner

scdoshi commented Jun 10, 2015

will be solved in v2.0: #57

@scdoshi scdoshi closed this as completed Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants