Skip to content

Added reference to the form submitted #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

LordZardeck
Copy link

Whenever the callback executes, you have no reference to the form it actually executed on. So if you called the plugin on more than one element, you can't have any interaction with that form. My pull request calls the callback in reference to the form that was submitted.

@scdoshi
Copy link
Owner

scdoshi commented Nov 10, 2015

This will break compatibility in a sneaky way for anyone already using an older version, because the order of arguments is different.

This is addressed in 2.0 (#57). I would suggest using that, or use your fork whichever works best. Could use help with people trying 2.0 though.

Closing this in the meantime.

@scdoshi scdoshi closed this Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants