Adds CommonJS/RequireJS support #56
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ;(function (factory) { | ||
| if (typeof define === 'function' && define.amd) { | ||
| define(['jquery'], factory); | ||
| } else if (typeof exports === 'object') { |
There was a problem hiding this comment.
not very familiar with requireJS, so I may be way off base here, but should this not be
else if (typeof module === 'object' && module && module.exports) {
There was a problem hiding this comment.
nvm. seems both would work based on this: https://github.com/substack/browserify-handbook#exports
scdoshi
added a commit
that referenced
this pull request
Jun 14, 2015
scdoshi
added a commit
that referenced
this pull request
Jun 14, 2015
|
will be covered in v2.0: #57 |
|
Just saw this, yes they both do the same thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for asynchronous module definitions (AMD) through both RequireJS and CommonJS. If neither is present, the plugin is added to the global jQuery.