Skip to content

Does Mr. MeeseeksDev like pandas? #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomAugspurger opened this issue Dec 11, 2017 · 9 comments
Closed

Does Mr. MeeseeksDev like pandas? #26

TomAugspurger opened this issue Dec 11, 2017 · 9 comments

Comments

@TomAugspurger
Copy link
Collaborator

If so, would he mind handling backports for us? :)

The pandas-people to add would be

  • jreback
  • jorisvandenbossche
  • gfyoung
  • TomAugspurger

Any other info you need? Our backports branches are named as 0.20.x for the backports that should go from master to 0.20.1, 0.20.2, etc.

Thanks!

@Carreau
Copy link
Contributor

Carreau commented Dec 11, 2017

Sure thing, done in 2c9b01c

You can edit your milestones descriptions like matplotlib does to include a on-merge: backport to 0.20.x then head there and enable the integration. The bot may need a restart after that; and yes I know I should ask for less permission, I still need to go through GitHub API docs and lower the permissions I request.

I can also give you access to the heroku instance to see error logs if you desire.

@Carreau
Copy link
Contributor

Carreau commented Dec 15, 2017

Did you had any chance to try ?

I've limited the permissions required quite a bit since you opened this issue.

@TomAugspurger
Copy link
Collaborator Author

Oh, sorry no. @jreback, I think you'll need to authorize it at https://github.com/integration/meeseeksdev/ since you're the admin. This should make backporting a bit easier.

@Carreau
Copy link
Contributor

Carreau commented Dec 15, 2017

Oh, sorry no. @jreback, I think you'll need to authorize it at integration/meeseeksdev since you're the admin. This should make backporting a bit easier.

No problem, just wanted to know if its working or not for you and if you need changes. I just got asked for another question and while I was taking care of it, wanted to check.

@Carreau
Copy link
Contributor

Carreau commented Feb 15, 2018

I've lifted the restriction on whitelisted users, but still have an org whitelist.

So you should not need me if you want to activate it.

cc'ing @stefanv who showed interest enabling the bot on scikit-image as well

@lumberbot-app
Copy link
Contributor

lumberbot-app bot commented Feb 15, 2018

Oweee !!! Happy to serve more people

@Carreau
Copy link
Contributor

Carreau commented May 22, 2018

I've now implemented (in beta) the ability to backport without requiring push permissions. See #28

I'll switch the default mechanism after some testing, and then remove the request for push access.

@TomAugspurger
Copy link
Collaborator Author

Working now. Thanks!

@Carreau
Copy link
Contributor

Carreau commented Jul 18, 2018

I've switched the default backport to a new version that should not ask for commit rights. Let me know if there is any issues. You can use legacy_backport if the new backport fails. Ping me if something's wrong.

If the new backport mechanism works, I'll retire the old one and decrease necessary permissions.

Carreau added a commit that referenced this issue Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants