Skip to content

Switch to src layout, move tests to root #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 17, 2025

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented May 17, 2025

Closes #147.

Also, somehow, closes #131. See #131 (comment).

$ du -sh dist/*         
12K	dist/lazy_loader-0.5rc0.dev0-py3-none-any.whl
16K	dist/lazy_loader-0.5rc0.dev0.tar.gz
$ tar -tf dist/*.tar.gz
lazy_loader-0.5rc0.dev0/
lazy_loader-0.5rc0.dev0/CHANGELOG.md
lazy_loader-0.5rc0.dev0/LICENSE.md
lazy_loader-0.5rc0.dev0/MANIFEST.in
lazy_loader-0.5rc0.dev0/PKG-INFO
lazy_loader-0.5rc0.dev0/README.md
lazy_loader-0.5rc0.dev0/pyproject.toml
lazy_loader-0.5rc0.dev0/setup.cfg
lazy_loader-0.5rc0.dev0/src/
lazy_loader-0.5rc0.dev0/src/lazy_loader/
lazy_loader-0.5rc0.dev0/src/lazy_loader/__init__.py
lazy_loader-0.5rc0.dev0/src/lazy_loader.egg-info/
lazy_loader-0.5rc0.dev0/src/lazy_loader.egg-info/PKG-INFO
lazy_loader-0.5rc0.dev0/src/lazy_loader.egg-info/SOURCES.txt
lazy_loader-0.5rc0.dev0/src/lazy_loader.egg-info/dependency_links.txt
lazy_loader-0.5rc0.dev0/src/lazy_loader.egg-info/requires.txt
lazy_loader-0.5rc0.dev0/src/lazy_loader.egg-info/top_level.txt
lazy_loader-0.5rc0.dev0/tests/
lazy_loader-0.5rc0.dev0/tests/__init__.py
lazy_loader-0.5rc0.dev0/tests/fake_pkg/
lazy_loader-0.5rc0.dev0/tests/fake_pkg/__init__.py
lazy_loader-0.5rc0.dev0/tests/fake_pkg/__init__.pyi
lazy_loader-0.5rc0.dev0/tests/fake_pkg/some_func.py
lazy_loader-0.5rc0.dev0/tests/import_np_parallel.py
lazy_loader-0.5rc0.dev0/tests/test_lazy_loader.py
$ unzip -l dist/*.whl
Archive:  dist/lazy_loader-0.5rc0.dev0-py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
    10909  05-17-2025 13:57   lazy_loader/__init__.py
     1539  05-17-2025 13:57   lazy_loader-0.5rc0.dev0.dist-info/licenses/LICENSE.md
     7515  05-17-2025 13:57   lazy_loader-0.5rc0.dev0.dist-info/METADATA
       91  05-17-2025 13:57   lazy_loader-0.5rc0.dev0.dist-info/WHEEL
       12  05-17-2025 13:57   lazy_loader-0.5rc0.dev0.dist-info/top_level.txt
      529  05-17-2025 13:57   lazy_loader-0.5rc0.dev0.dist-info/RECORD
---------                     -------
    20595                     6 files

Copy link

codecov bot commented May 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.27%. Comparing base (024e49f) to head (79aa9d0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   96.00%   87.27%   -8.73%     
==========================================
  Files           5        1       -4     
  Lines         250      110     -140     
  Branches        0       20      +20     
==========================================
- Hits          240       96     -144     
+ Misses         10        7       -3     
- Partials        0        7       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefanv
Copy link
Member

stefanv commented May 17, 2025

Thanks, @effigies! src layout isn't common in the SP ecosystem, but I don't feel strongly about it. Not sure I follow why this closes #131 🤷‍♂️

@stefanv stefanv merged commit 44c7010 into scientific-python:main May 17, 2025
25 of 26 checks passed
@effigies effigies deleted the src-layout branch May 17, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants