Skip to content

Feat search #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 18 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
.DEFAULT_GOAL := help
SHELL:=/bin/bash


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unrelated edit.

# Add help text after each target name starting with '\#\#'
help: ## show this help
@echo -e "Help for this makefile\n"
Expand Down Expand Up @@ -30,6 +29,7 @@ SPEC_DIR = content/specs/steering-committee
TEAMS = community-managers community-leaders emeritus-community-leaders
SPEC_TEAMS = spec-steering-committee emeritus-spec-steering-committee
TEAMS_QUERY = python themes/scientific-python-hugo-theme/tools/team_query.py
SEARCH = (echo "Installing \`pagefind\` and generating search index..." && npx --yes pagefind --site public)

$(TEAMS_DIR)/%.toml:
$(TEAMS_QUERY) --org scientific-python --team "$*" > $(TEAMS_DIR)/$*.toml
Expand All @@ -55,12 +55,18 @@ content/specs/core-projects/core-projects.json: content/specs/core-projects/[^_]
@python tools/md-header-to-json.py $? > $@

html: prepare calendars core-project-json ## build the website in ./public
hugo --themesDir="./themes";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to just add:

hugo;  $(SEARCH)

to the prepare target and remove it everywhere else. (I also removed the --themesDir option.

$(SEARCH)
@hugo

serve: prepare calendars core-project-json ## serve the website
hugo --themesDir="./themes";
$(SEARCH)
@hugo --printI18nWarnings server

serve-dev: prepare calendars
hugo --themesDir="../";
$(SEARCH)
@hugo --printI18nWarnings server --disableFastRender

clean:
Expand Down
2 changes: 1 addition & 1 deletion config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ params:
author:
name: Scientific Python team
description: Community developed and owned ecosystem for scientific computing

search: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be enough to pull in the JS and CSS from the theme.

fonts:
- name: "Lato"
weights: [400, 900]
Expand Down