Skip to content

Add MeeseeksDev / Lumberbot (App) to GitHub page #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert added the type: Enhancement New feature or request label Jun 6, 2024
@matthewfeickert matthewfeickert self-assigned this Jun 6, 2024
Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for tools-scientific-python-org ready!

Name Link
🔨 Latest commit 796499c
🔍 Latest deploy log https://app.netlify.com/sites/tools-scientific-python-org/deploys/6660fdd815b1ad0008bd005a
😎 Deploy Preview https://deploy-preview-49--tools-scientific-python-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86
Accessibility: 96
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -55,4 +55,11 @@ body = '''
Add a GitHub status link directly to a CircleCI artifact.
'''

[[item]]
type = 'card'
header = '[MeeseeksDev / Lumberbot (App)](https://github.com/scientific-python/MeeseeksDev)'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Carreau has moved the bot to the Scientific Python org, but we're going to rename it later once we have validated everything works. We can do a follow up PR once that has been done.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewfeickert matthewfeickert requested a review from a team June 6, 2024 00:09
@matthewfeickert
Copy link
Member Author

Sorry, I forgot that I could just hit @scientific-python/tools-team for review.

Copy link
Member

@j-bowhay j-bowhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now, but I would suggest a follow up to separate the actions and apps into either separate sections in the same page, or into separate pages.

I would prefer the separate sections as we only have one bot.

@j-bowhay j-bowhay merged commit 5959319 into scientific-python:main Jun 6, 2024
5 checks passed
@matthewfeickert matthewfeickert deleted the feat/add-backport-bot branch June 6, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants