Skip to content

fix: pin CI build dependencies (cmake & ninja) #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2021

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Jul 3, 2021

Prevents a race condition on release, ensures reproducibility.

relates to #159

@mayeut
Copy link
Contributor Author

mayeut commented Jul 3, 2021

Build will need to be triggered again on travis-ci once there are credits available again.

@mayeut mayeut mentioned this pull request Jul 4, 2021
@henryiii
Copy link
Contributor

henryiii commented Jul 4, 2021

Do you think we could drop these in a requirements file and then use dependabot to keep it updated? That's the "good" use for requirements files. :)

@mayeut
Copy link
Contributor Author

mayeut commented Jul 5, 2021

Do you think we could drop these in a requirements file and then use dependabot to keep it updated? That's the "good" use for requirements files. :)

That's definitely doable as long as we don't require hashes (c.f. pypa/pipx#712)

@mayeut
Copy link
Contributor Author

mayeut commented Jul 6, 2021

Do you think we could drop these in a requirements file and then use dependabot to keep it updated? That's the "good" use for requirements files. :)

Now done.
I used a constraint file rather than requirements*.txt as it is used as a constraint file.
It only includes cmake & ninja for now. cibuildwheel could be added later for Travis CI for example (or twine for pipx run twine ...).

There was an issue with manylinux images pipx wrapper pypa/manylinux#1131 found when investigating
pypa/pipx#712 that required to update all manylinux images in pyproject.toml

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thewtex thewtex merged commit 2cb435e into scikit-build:master Jul 9, 2021
@mayeut mayeut deleted the pin-ci-build-dependencies branch July 14, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants