Skip to content

chore: add 3.14 beta 1 support #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 14, 2025
Merged

chore: add 3.14 beta 1 support #1074

merged 5 commits into from
May 14, 2025

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented May 7, 2025

Trying this out.

@henryiii
Copy link
Collaborator Author

henryiii commented May 8, 2025

I thought the beta was showing up, but I guess testing triggered the notification. As soon as the beta is available, we should rebase and merge if it passes.

There's a warning from pluggy: pytest-dev/pluggy#573

@LecrisUT
Copy link
Collaborator

LecrisUT commented May 8, 2025

Epel10 hatchling:

ValueError: Unknown classifier in field `project.classifiers`: Programming Language :: Python :: 3.14

Well this will be fun. Let me check if they plan yo update it in centos. I will add a workaround until that gets resolved

@henryiii
Copy link
Collaborator Author

henryiii commented May 8, 2025

Windows is failing with:

LINK : fatal error LNK1104: cannot open file 'python314t.lib' 

That's on the normal 3.14 build, I didn't add a 3.14t yet.

@henryiii
Copy link
Collaborator Author

henryiii commented May 8, 2025

Epel10 hatchling:

ValueError: Unknown classifier in field `project.classifiers`: Programming Language :: Python :: 3.14

Well this will be fun. Let me check if they plan yo update it in centos. I will add a workaround until that gets resolved

HATCH_METADATA_CLASSIFIERS_NO_VERIFY Disables it. Though it’s actually the trove-classifiers package that needs updating, I think.

@henryiii
Copy link
Collaborator Author

henryiii commented May 8, 2025

On Windows, hitting:

LINK : fatal error LNK1104: cannot open file 'python314t.lib'

This isn't supposed to use the free-threaded build, though.

@henryiii henryiii force-pushed the henryiii/chore/py314 branch from 9e7a62e to 269bfbb Compare May 8, 2025 22:14
@henryiii
Copy link
Collaborator Author

henryiii commented May 8, 2025

How do you set an environment variable (HATCH_METADATA_CLASSIFIERS_NO_VERIFY) there?

@LecrisUT
Copy link
Collaborator

LecrisUT commented May 9, 2025

How do you set an environment variable (HATCH_METADATA_CLASSIFIERS_NO_VERIFY) there?

You can add it as

  %generate_buildrequires
+ %if 0%{rhel}
+ export HATCH_METADATA_CLASSIFIERS_NO_VERIFY=1
+ %endif
  %pyproject_buildrequires -x test,test-meta,test-numpy
  
  
  %build
+ %if 0%{rhel}
+ export HATCH_METADATA_CLASSIFIERS_NO_VERIFY=1
+ %endif
  %pyproject_wheel

Edit: added the commit with some documentation about the reason

@henryiii
Copy link
Collaborator Author

henryiii commented May 9, 2025

Opened upstream issue at https://gitlab.kitware.com/cmake/cmake/-/issues/26926 for Windows, also seeing it in pybind11's test suite, which doesn't use scikit-build-core.

@LecrisUT
Copy link
Collaborator

Weird issue. Shouldn't have this come up in 3.13 as well? Hopefully it is not github action specific.

henryiii and others added 4 commits May 14, 2025 00:50
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii force-pushed the henryiii/chore/py314 branch from 0c8e3a5 to 2448cad Compare May 14, 2025 04:50
@henryiii henryiii marked this pull request as ready for review May 14, 2025 06:25
@henryiii henryiii merged commit bdf5a4a into main May 14, 2025
61 checks passed
@henryiii henryiii deleted the henryiii/chore/py314 branch May 14, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants