Initial support for cmake.preset
#994
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LecrisUT
force-pushed
the
preset
branch
2 times, most recently
from
1c4ae1f to
9f9b879
Compare
LecrisUT
commented
Feb 19, 2025
| @@ -273,8 +273,12 @@ def __init__( | |||
| new_min_cmake = "3.15" | |||
| self.settings.cmake.version = SpecifierSet(f">={new_min_cmake}") | |||
|
|
|||
| default_cmake_minimum = "3.15" | |||
| if self.settings.cmake.preset: | |||
| default_cmake_minimum = "3.19" | |||
There was a problem hiding this comment.
I don't think I am handling this part correctly. Generally it should not be tied to the auto-cmake version, but not sure where to feed it to override potential values set by the user. Or we just fail it at builder.cmake?
LecrisUT
force-pushed
the
preset
branch
2 times, most recently
from
4cfc481 to
cf19fc1
Compare
Signed-off-by: Cristian Le <[email protected]>
LecrisUT
commented
Feb 20, 2025
| "OVERWRITTEN_VAR": "original" | ||
| }, | ||
| "binaryDir": "/dev/null", | ||
| "generator": "Ninja" |
There was a problem hiding this comment.
Windows disapproves, but empty generator is only available in version 3. Not sure if I can bump it and satisfy the other builders. What generator value is available on windows?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #790 I commented that we could support
configurePresetsif we overwrite thebinarydir. It seems to work fine, but I realized we still have an issue to discuss how to deal with the generator. My thinking is that depending onmake-fallbackvalue and ifpresetis present we deffer to the value ofpresetand let it handle the rest. Although not sure how to detect/handle multi-config then, but wouldn't it build all configs if it wasn't specified explicitly? The documentation ofmake-fallbackis also confusing me a bit.PS: it took me way too long to figure out
nox -t genwas a thing 🤦