Forward purelist_parameter "__doc__" in lazy slices #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to "__record__" since both are queried in every highlevel array instantiation.
nsmith-
commented
Aug 28, 2020
| @@ -615,13 +621,8 @@ namespace awkward { | |||
| ArrayGeneratorPtr generator = std::make_shared<SliceGenerator>( | |||
| form, carry.length(), shallow_copy(), slice); | |||
| ArrayCachePtr cache(nullptr); | |||
| util::Parameters params(parameters_); | |||
There was a problem hiding this comment.
There is one case where the parameters were copied from the parent VirtualArray. I decided it was a non-uniformity and dropped it. We could instead always copy the parameters if that makes more sense.
jpivarski
approved these changes
Aug 28, 2020
|
Of course in the long run it will be better to have #402 but for now it is 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to
__record__since both are queried in every highlevel array instantiation.This is a follow-up to #390