Skip to content

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented May 18, 2021

Followup to #576, supporting sequences of bin numbers for categorical axes (needs more tests).

@github-actions github-actions bot added the needs changelog Might need a changelog entry label May 18, 2021
@henryiii henryiii force-pushed the henryiii/feat/pickcat branch 2 times, most recently from 435c1e4 to 6b443a7 Compare May 19, 2021 02:00
@henryiii henryiii marked this pull request as draft May 19, 2021 13:09
@henryiii
Copy link
Member Author

Also needs bh.loc support.

@henryiii henryiii force-pushed the henryiii/feat/pickcat branch from 6b443a7 to 2cfb856 Compare July 6, 2021 03:23
@henryiii henryiii force-pushed the henryiii/feat/pickcat branch from 2cfb856 to 1c51fc7 Compare July 6, 2021 17:46
@henryiii henryiii marked this pull request as ready for review July 6, 2021 18:04
@henryiii henryiii changed the title feat: support selecting on categorical axes feat: support selecting on categorical axes (experimental) Jul 6, 2021
@henryiii
Copy link
Member Author

henryiii commented Jul 6, 2021

I'm going to merge this as an experimental feature so we can release for PyHEP. It currently does not support adding the removed axes to the flow bins, but eventually it should. It prints an "Experimental" warning if used.

@henryiii henryiii merged commit 887b40d into develop Jul 6, 2021
@henryiii henryiii deleted the henryiii/feat/pickcat branch July 6, 2021 21:37
@henryiii henryiii removed the needs changelog Might need a changelog entry label Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant