Skip to content

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Jan 24, 2022

Quick outline of the changes inspired by pylint:

  • Use f-strings everywhere possible
  • Use guard-style everywhere (simpler control flow)
  • Minor import cleanup
  • Cleanup of some reused and redefined variables

I've disabled quite a few pylint checks because it is known for going too far on false positives. But some of the checks are pretty useful.

@github-actions github-actions bot added the needs changelog Might need a changelog entry label Jan 24, 2022
@henryiii henryiii force-pushed the henryiii/chore/pylint branch 5 times, most recently from ab7e9e2 to 4647122 Compare January 24, 2022 19:49
@henryiii henryiii force-pushed the henryiii/chore/pylint branch from 4647122 to b46fe08 Compare January 24, 2022 19:56
@henryiii henryiii merged commit 9f5a944 into develop Jan 24, 2022
@henryiii henryiii deleted the henryiii/chore/pylint branch January 24, 2022 20:04
@henryiii henryiii removed the needs changelog Might need a changelog entry label Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant