Use pypa readme renderer to figure out how to handle images

[kratsg]

Question

https://github.com/pypa/readme_renderer seems to be what is used to generate the html page for the README. It seems this should have been fixed according to linked issues/PRs below. But we definitely have issues with the image size of the stackoverflow logo at the bottom here: https://test.pypi.org/project/pyhf/0.4.2.dev20/ . It seems the width attribute is still being stripped from the rST.

Relevant Issues and Pull Requests

• width tag not respected for images pypa/readme_renderer#44
• Width and alignment of RST images pypa/readme_renderer#114

[matthewfeickert]

@dstufft @theacodes @di if you have thoughts/advice here, we would be interested in them. If you would prefer, we can also open up an Issue on readme_renderer.

[di]

There was a regression (mentioned here) that should be fixed by pypa/readme_renderer#164.

[matthewfeickert]

There was a regression (mentioned here) that should be fixed by pypa/readme_renderer#164.

Many thanks for the super speedy diagnosis and reply!

[matthewfeickert]

Given @di's super awesome responsiveness the fix for this (pypa/readme_renderer#164) has already gone into a new major release v26.0 in pypa/readme_renderer#165! As explained in his comment

old descriptions should get eventually re-rendered, so you shouldn't have to make a new release to see the update (although new releases will definitely get it right away).

So there should be no further action to take on this. 🚀

I won't formally close this Issue until we notice that things render properly on TestPyPI (with prep for patch release v0.4.2 we'll be checking there frequently anyway), but this Issue is resolved now. 👍

[matthewfeickert]

Closing this now as TestPyPI is rendering fine. 👍