ci: fixing baseurl #395
ci: fixing baseurl #395
Conversation
|
Thanks for trying this out, Henry! Do we need to wait for this PR to get merged to then get a preview in a new PR? Guessing so :). |
|
No, you can click on the readthedocs "check" below and see the preview. But the URLs are messed up so things like the css doesn't load, so working that out. |
henryiii
force-pushed
the
henryiii/ci/rtd-fix
branch
3 times, most recently
from
79d5b33 to
1fb9282
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/ci/rtd-fix
branch
2 times, most recently
from
6d63e12 to
59fd488
Compare
|
The homepage is now previewed nicely - cool! - but all left-menu links (at least, did not check everything) give a 404. There's still some issue with the pages, I'm afraid. |
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/ci/rtd-fix
branch
from
aba3755 to
0a81ca7
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/ci/rtd-fix
branch
from
5eb8f5c to
936b541
Compare
for more information, see https://pre-commit.ci
|
I think it's fixed now. |
|
I'll go ahead and merge so I can check (and fix if needed) the main site. Local builds and PR previews seem fine. |
|
Hey. Many thanks! All looks good except the rendering of https://scikit-hepgithubio--395.org.readthedocs.build/en/395/packages/qr_codes/, which shows links but not the figures rendered. This being said, all seems fine at https://scikit-hep.org/packages/qr_codes/, actually. |
Incorrect baseurl calculation.