Skip to content

DOC: Update derivation equations of positive Group Lasso penalty #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Aishwarya0811
Copy link

Context of the PR

Contributions of the PR

  • Complete mathematical derivation for the subdifferential case w = 0 including full Lagrangian formulation
  • Rigorous KKT conditions and complementary slackness analysis with step-by-step mathematical proof
  • Replacement of incomplete placeholder text with actual mathematical derivations from the reference document
  • Improved mathematical notation consistency throughout the tutorial
  • Complete mathematical derivation for the subdifferential case w = 0 including full Lagrangian formulation
  • Rigorous KKT conditions and complementary slackness analysis with step-by-step mathematical proof
  • Replacement of incomplete placeholder text with actual mathematical derivations from the reference document
  • Improved mathematical notation consistency throughout the tutorial

Checks before merging PR

  • added documentation for any new feature
  • added unit tests
  • edited the what's new (if applicable)

- Add complete Lagrangian derivation for case w = 0
- Include rigorous KKT conditions and optimality analysis
- Replace incomplete derivations with full mathematical proofs

Fixes scikit-learn-contrib#243
@Badr-MOUFAD
Copy link
Collaborator

Thanks @Aishwarya0811 for the PR!

You mistakenly pushed the files _double_quadratic.py and test_double_quadratic.py, ... which are unrelated to this PR, can you remove them?

- Add complete Lagrangian derivation for case w = 0
- Include rigorous KKT conditions and optimality analysis
- Replace incomplete derivations with full mathematical proofs

Fixes scikit-learn-contrib#243
@Aishwarya0811
Copy link
Author

Hi @Badr-MOUFAD!
Got it fixed! I removed those unrelated files - they were from my previous PR and somehow got mixed in here.
The PR is now clean and only has the documentation updates for issue #243.
Tests are all green, so it should be good to go. Let me know if you need any tweaks!

Thanks for the quick feedback 👍

Copy link

@malakazlan malakazlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation with formula is nicely done and correctly now .Thanks for contribution.

@Aishwarya0811
Copy link
Author

Thank you @malakazlan for review on PR 😀

@Aishwarya0811
Copy link
Author

@mathurinm @Badr-MOUFAD
I’ve cleaned up the PR as requested — it now only includes the updated derivations for positive Group Lasso (issue #243).
Would you mind taking another look and approving when you get a chance?
Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants